Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizations need to bubble Filters up through embeddable layer #43411

Closed
Tracked by #32371
stacey-gammon opened this issue Aug 15, 2019 · 6 comments
Closed
Tracked by #32371
Assignees
Labels
Feature:Embedding Embedding content via iFrame Feature:Filters Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@stacey-gammon
Copy link
Contributor

They shouldn't interact with the global filter bar directly but instead use triggers and actions the same way maps and saved searches do.

cc @streamich @ppisljar

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@streamich streamich added this to To do in Embeddables via automation Aug 16, 2019
@stacey-gammon
Copy link
Contributor Author

@ppisljar - I could be wrong but I recall you saying this wouldn't be too difficult to implement. Is there a chance you'd be able to prioritize it for 7.4? Canvas team currently has a bad experience with filtering embeddables, they are throwing exceptions. If we can implement this issue and then #9220 I think we can make for a much better canvas embeddable experience in 7.4. @streamich or I could work on #9220 if this is solved.

cc @crob611 @clintandrewhall

@crob611
Copy link
Contributor

crob611 commented Aug 23, 2019

In Canvas, we don't have a solution for handling filter changes pushed up right now, so #9220 would be more important for us at this point.

But for a future release, being able to respond to the filters would be helpful.

@stacey-gammon
Copy link
Contributor Author

This is a pre-req for #9220 (at least if we want it to disable filter actions on visualizations). We can disable actions but unless the visualization infrastructure is actually using action infrastructure, it won't make any difference.

@ppisljar
Copy link
Member

ppisljar commented Aug 26, 2019

i think this should be easy but 7.4 is too close so i think it won't make it in 7.4, but i can make sure this gets in soon after the feature freeze.

@streamich streamich moved this from To do to 7.5 in Embeddables Aug 27, 2019
@streamich streamich added Feature:Embedding Embedding content via iFrame Feature:Filters Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Aug 27, 2019
@streamich streamich added 2sp and removed 2sp labels Aug 27, 2019
@streamich streamich moved this from 7.5 to 7.6 in Embeddables Sep 25, 2019
@streamich streamich added 3sp and removed 5sp labels Sep 27, 2019
@alexh97 alexh97 added this to To do in kibana-app-arch via automation Sep 27, 2019
@alexh97 alexh97 moved this from To do to 7.5 in kibana-app-arch Sep 27, 2019
@streamich streamich moved this from 7.6 to 7.5 in Embeddables Oct 2, 2019
@ppisljar ppisljar moved this from 7.5 to In progress in kibana-app-arch Oct 3, 2019
@ppisljar ppisljar mentioned this issue Oct 3, 2019
7 tasks
@streamich streamich moved this from In progress to 7.5 in kibana-app-arch Oct 3, 2019
@alexh97 alexh97 moved this from 7.5 to In progress in kibana-app-arch Oct 9, 2019
@streamich streamich moved this from 7.5 to 7.6 in Embeddables Oct 24, 2019
@ppisljar
Copy link
Member

resolved by #50319

Embeddables automation moved this from 7.6 to Done in 7.6 Nov 12, 2019
kibana-app-arch automation moved this from In progress to Done in 7.6 Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Embedding Embedding content via iFrame Feature:Filters Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
kibana-app-arch
  
Done in previous release
Embeddables
  
Done in 7.6
Development

No branches or pull requests

5 participants