Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Kibana crashes when clicking on a region in a map visualization #44050

Closed
cqliu1 opened this issue Aug 26, 2019 · 3 comments
Closed
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects

Comments

@cqliu1
Copy link
Contributor

cqliu1 commented Aug 26, 2019

Kibana version:
7.4.0+

Elasticsearch version:

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:

I added the [Ecommerce] Average Sales per Region visualization, and I'm getting this error when I click on a country in the map. It looks like it's trying to add a filter but can't. Not sure if it's related to this PR or if I should file a separate issue. Confirmed this is an issue in master and filed an issue #

Steps to reproduce:

  1. Install the ecommerce
  2. Navigate to Canvas
  3. Create a new workpad
  4. Click on Embed Object
  5. Add the [Ecommerce] Average Sales per Region visualization
  6. Click on a country
  7. Observe the error.

Expected behavior:
Either a filter should be applied, or the regions should not be interactable

Screenshots (if relevant):

Screen Shot 2019-08-26 at 4 17 42 PM

Errors in browser console (if relevant):

Error: pushFilters requires a state object
    at pushFilterBarFilters (commons.bundle.js:185613)
    at Object.pushFilters (commons.bundle.js:187007)
    at SafeSubscriber._next (commons.bundle.js:198179)
    at SafeSubscriber.__tryOrUnsub (Subscriber.js:205)
    at SafeSubscriber.next (Subscriber.js:143)
    at Subscriber._next (Subscriber.js:87)
    at Subscriber.next (Subscriber.js:64)
    at RefCountSubscriber.Subscriber._next (Subscriber.js:87)
    at RefCountSubscriber.Subscriber.next (Subscriber.js:64)
    at Subject.next (Subject.js:57)

Any additional context:
This is a map visualization saved object and not a map saved object.

@cqliu1 cqliu1 added bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Aug 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@crob611
Copy link
Contributor

crob611 commented Aug 26, 2019

Embedded visualizations try to directly manipulate the filter bar when filter interactions occur.

#43411 is going to make those filters bubble up through embeddable actions instead so that anyone can handle those filter interactions as they choose.

@nreese
Copy link
Contributor

nreese commented Aug 27, 2019

closing, duplicate of #43713

@nreese nreese closed this as completed Aug 27, 2019
@kibanamachine kibanamachine added this to Inbox in Canvas Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
No open projects
Canvas
  
Inbox
Development

No branches or pull requests

5 participants