Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Allow users to perform cleanup action for a repository #43904

Closed
jen-huang opened this issue Aug 23, 2019 · 5 comments · Fixed by #53047
Closed

[SR] Allow users to perform cleanup action for a repository #43904

jen-huang opened this issue Aug 23, 2019 · 5 comments · Fixed by #53047
Assignees
Labels
enhancement New value added to drive a business result Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jen-huang
Copy link
Contributor

jen-huang commented Aug 23, 2019

Describe the feature:
A new ES endpoint was added by elastic/elasticsearch#43900.
POST /_snapshot/{repository_name}/_cleanup will cleanup unreferenced data in the given repository.

Snapshot and Restore > Repositories should surface this action in the existing UI as a single action (on each repository row, and in its details, but not available as a bulk action when selecting multiple repositories).

@jen-huang jen-huang added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI labels Aug 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@jen-huang
Copy link
Contributor Author

@original-brownbear, does this new endpoint support cleaning up multiple repositories at a time, or _all? Are there any negative consequences if the user sends this request in rapid succession? This will help us figure out if we should surface this in the UI as a "single" action or a "bulk" action (such as selecting multiple repositories in the table for deletion).

@jen-huang jen-huang added enhancement New value added to drive a business result low hanging fruit labels Aug 23, 2019
@original-brownbear
Copy link
Member

@jen-huang

does this new endpoint support cleaning up multiple repositories at a time, or _all?

No, it only works on a single repository at a time.

Are there any negative consequences if the user sends this request in rapid succession?

Not really. But note that you can only run a single cleanup operation at a time, so if "rapid succession" means sending requests in parallel then you will get errors (exactly like those you get when trying to run snapshot create or delete in parallel).

@jen-huang
Copy link
Contributor Author

Thanks @original-brownbear, I've updated the description to specify that it should be implemented in the UI as a single action (not available as a bulk action).

@cjcenizal
Copy link
Contributor

Based on this behavior, we should also make sure the UI handles this error gracefully and surfaces it to the user in a way they can understand, e.g. a toast or callout stating, "Your previous cleanup is still in progress. Wait a few seconds and try again."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants