alerting/transformActionParams does not handle arrays

[pmuellr]

current version of code:

kibana/x-pack/legacy/plugins/alerting/server/lib/transform_action_params.ts

Lines 7 to 23 in 19c85d6

	import Mustache from 'mustache';
	import { isPlainObject } from 'lodash';
	import { AlertActionParams, State, Context } from '../types';
	export function transformActionParams(params: AlertActionParams, state: State, context: Context) {
	const result: AlertActionParams = {};
	for (const [key, value] of Object.entries(params)) {
	if (isPlainObject(value)) {
	result[key] = transformActionParams(value as AlertActionParams, state, context);
	} else if (typeof value !== 'string') {
	result[key] = value;
	} else {
	result[key] = Mustache.render(value, { context, state });
	}
	}
	return result;
	}

Arrays end up getting treated as objects, where the indices become string keys. Those objects end up failing schema validation.

On a lark, I re-wrote the function like this, which seemed to work for my purpose, but didn't run any tests:

import Mustache from 'mustache';
import { isString, cloneDeep } from 'lodash';
import { AlertActionParams, State, Context } from '../types';

export function transformActionParams(params: AlertActionParams, state: State, context: Context) {
  return cloneDeep(params, value => {
    if (!isString(value)) return;

    return Mustache.render(value, { context, state });
  });
}

[elasticmachine]

Pinging @elastic/kibana-stack-services