Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update kibana/.github/CODEOWNERS to accurately reflect AppArch team areas #45829

Closed
alexh97 opened this issue Sep 16, 2019 · 3 comments · Fixed by #51502
Closed

[chore] Update kibana/.github/CODEOWNERS to accurately reflect AppArch team areas #45829

alexh97 opened this issue Sep 16, 2019 · 3 comments · Fixed by #51502
Labels

Comments

@alexh97
Copy link
Contributor

alexh97 commented Sep 16, 2019

CODEOWNERS setup doesn't accurately reflect Application Architecture team's areas of responsibility. This results in PRs not being automatically assigned to the team for review. The current practice is for developers to manually add the team as a reviewer.

We should update the CODEOWNERS setup to reflect the directories that should fall under App Arch area of responsibility.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@streamich
Copy link
Contributor

Was actually adding some of our folders in this PR: https://github.com/elastic/kibana/pull/47810/files#diff-5cfb934ca0ec4c1743905a51dc428b84R11-R17

@lukeelmers
Copy link
Member

I added #51502 to include some not-yet-migrated legacy plugins so that we can close this issue.

At this point we should have a list of plugins that is comprehensive (AFAIK)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants