Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Platform] Expose serverBasePath #45991

Closed
rudolf opened this issue Sep 18, 2019 · 1 comment
Closed

[New Platform] Expose serverBasePath #45991

rudolf opened this issue Sep 18, 2019 · 1 comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@rudolf
Copy link
Contributor

rudolf commented Sep 18, 2019 •
edited by azasypkin
Loading

Spaces, Security, Alerting and Actions plugins require access to the legacy server.basePath value.

We can expose this as core.http.basePath.serverBasePath
@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Sep 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@rudolf rudolf mentioned this issue Sep 18, 2019
Merged
rudolf added a commit to rudolf/kibana that referenced this issue Sep 18, 2019
@rudolf
Expose serverBasePath fixes elastic#45991
4d0ff48
@rudolf rudolf closed this as completed in 08b8678 Sep 30, 2019
@rudolf rudolf mentioned this issue Sep 30, 2019
Merged
rudolf added a commit to rudolf/kibana that referenced this issue Sep 30, 2019
@rudolf
Expose serverBasePath fixes elastic#45991 (elastic#45995)
837ee95 
* Expose serverBasePath fixes elastic#45991

* Review comments

* Fix basepath mock types

* AppBasePathContract -> IBasePath

* Match basepath test description with assertion

* Fix eslint errors
rudolf added a commit that referenced this issue Oct 1, 2019
@rudolf
Expose serverBasePath fixes #45991 (#45995) (#46966)
1e2f6d8 
* Expose serverBasePath fixes #45991

* Review comments

* Fix basepath mock types

* AppBasePathContract -> IBasePath

* Match basepath test description with assertion

* Fix eslint errors
@joshdover joshdover mentioned this issue Feb 13, 2020
Closed
@zhongnansu zhongnansu mentioned this issue Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rudolf @elasticmachine