Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny UI text issue in Management > Advanced settings page (Dark mode setting) #46622

Open
Titch990 opened this issue Sep 25, 2019 · 11 comments
Open
Labels
enhancement New value added to drive a business result Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:uiSettings impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) triage_needed

Comments

@Titch990
Copy link
Contributor

Kibana version: 7.4

Describe the bug:

Three small things about the dark mode setting and the related text.

  1. The dark mode setting is currently buried near the end of the Management > Advanced settings page, and below the warning banner saying "Be careful in here, these settings are for very advanced users only." Is that really the case? Would this setting be better nearer the top where it's visible, and perhaps above the warning banner? And is it a space setting or a personal setting? I understand that it may be better left as it is if it will affect every user of the space, but I assume it's a personal setting? If it really is a space setting, it could be helpful to mention the fact.

  2. The UI text beside the dark mode setting says "A page refresh is required for the setting to be applied." but if you actually select dark mode, you get a helpful prompt that asks you to reload (not refresh) the page. Do we have a preferred word?

  3. The default value is shown as false but the toggle text is On/Off

Perhaps one for @gchaps?

@mikecote mikecote added Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed labels Sep 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@gchaps
Copy link
Contributor

gchaps commented Sep 27, 2019

@cchaos Can you please comment on this issue?

@cchaos
Copy link
Contributor

cchaos commented Sep 27, 2019

Yes we'd love to have dark mode be part of user settings and not buried under Advanced Settings. However, there's no architecture setup for user settings at the moment so this is the only place in can live for now.

I think all the text changes are viable. Advanced settings actually falls under @elastic/kibana-app-arch. I'll change the labels.

@cchaos cchaos added Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 27, 2019
@timroes
Copy link
Contributor

timroes commented Sep 27, 2019

These are actually kind of three different issues in one. For (1) I would refer to #14791 for discussion. For (2) we can align the wording here, just would like an input from @gchaps which way we should rather go. (3) We currently show the technical default values, i.e. what’s actually saved, this would be an enhancement if we want to show default values kind of formatted

@gchaps
Copy link
Contributor

gchaps commented Sep 27, 2019

For 2), I suggest this wording:

Enable dark mode for the Kibana UI. Reload the page to apply the setting.

For 3), Is the wording Default: false and Reset to default needed?

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@mattkime mattkime added Team:DataVis Team label for DataVis Team and removed Team:AppServicesSv labels Oct 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/datavis (Team:DataVis)

@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Oct 7, 2021
@nickofthyme nickofthyme added enhancement New value added to drive a business result Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed Team:DataVis Team label for DataVis Team labels Oct 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@yuliacech yuliacech added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@yuliacech yuliacech removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Oct 7, 2021
@afharo
Copy link
Member

afharo commented Dec 1, 2021

I think 1) is similar to #108723.

@TinaHeiligers TinaHeiligers added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Feb 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:uiSettings impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) triage_needed
Projects
None yet
Development

No branches or pull requests