Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Move sort out of top hits configuration #47279

Closed
nreese opened this issue Oct 3, 2019 · 6 comments
Closed

[Maps] Move sort out of top hits configuration #47279

nreese opened this issue Oct 3, 2019 · 6 comments
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation discuss

Comments

@nreese
Copy link
Contributor

nreese commented Oct 3, 2019

#46882 requests for sorting top hits by number fields instead of time fields. As I started to look into the implementation it occurred to me, "Hey, why do we bury sort input under top hits? Won't users want to sort regular searches as well"

Implementing #46882 will require a saved object migration because the sort state is stored in a field called topHitsTimeField. That name is not generic enough to support numbers. As long as I have to change the name, why not just change it to sortField and move the sort UI out of top hits and let users to sort all Elasticsearch documents, not just those with top hits?

Thoughts?

@nreese nreese added discuss [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Oct 3, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@bcamper
Copy link

bcamper commented Oct 3, 2019

Sounds reasonable. How else would a general sorting parameter affect the map results, outside of the "top hits" option?

  • If the # of results is limited by query limit (sorting is a bandaid to return most relevant results, but hoping we eliminate this one anyway).
  • For visual sorting top-to-bottom on the map? This would be genuinely useful to have control over.
  • Any others?

I'd also like us to be mindful of not giving the user too many choices up front. But that also can be solved more generally by moving some options to Advanced (for example) in the future.

@nreese
Copy link
Contributor Author

nreese commented Oct 3, 2019

I'd also like us to be mindful of not giving the user too many choices up front

I think we already do a good job of this. When you create a layer, the only options are index pattern and geo field. All of these other options are only visible when editing a layer so users get to see dots a on a a map before getting presented with too many inputs

@bcamper
Copy link

bcamper commented Oct 4, 2019

@nreese is my assumption about the sorting affecting visual ordering accurate?

@nreese
Copy link
Contributor Author

nreese commented Oct 4, 2019

yes, the items are visualized in the order they are returned

@thomasneirynck
Copy link
Contributor

Closed by #47361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation discuss
Projects
None yet
Development

No branches or pull requests

4 participants