[Maps] Move sort out of top hits configuration for ES documents source #47361
Conversation
nreese
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
💔 Build Failed |
|
cc @Alex3k This PR allows you to sort top hits by numerical fields if you want to try it out and ensure this solves your use case |
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
another failure in machine_learning/anomaly_detection/saved_search_job·ts retest |
| disabled={!this.props.sortField} | ||
| options={[ | ||
| { text: 'ASC', value: SORT_ORDER.ASC }, | ||
| { text: 'DESC', value: SORT_ORDER.DESC } |
There was a problem hiding this comment.
ascending/descending fully spelled out? (and localize i18n too)
There was a problem hiding this comment.
I am hesitant to do this since spelling out ascending/descending will take a lot of horizontal space and shorten the sort field select. IMHO, the sort field select needs to be as long as possible to handle long field names. Spelling out asc/desc adds little value compared to more room for long field names
There was a problem hiding this comment.
Maybe I could change the select to just an up or down icon?
There was a problem hiding this comment.
A fully spelled out "Ascending" and "Descending" select box appears to be consistent with other visualizations.
| @@ -56,9 +56,10 @@ export class ESSearchSource extends AbstractESSource { | |||
| geoField: descriptor.geoField, | |||
| filterByMapBounds: _.get(descriptor, 'filterByMapBounds', DEFAULT_FILTER_BY_MAP_BOUNDS), | |||
| tooltipProperties: _.get(descriptor, 'tooltipProperties', []), | |||
| sortField: _.get(descriptor, 'sortField', ''), | |||
| sortOrder: _.get(descriptor, 'sortOrder', SORT_ORDER.DESC), | |||
There was a problem hiding this comment.
consider wrapping this in single config object
sort: {
order: ...,
field: ...
}
looks a little cleaner, as they are co-dependent
x-pack/legacy/plugins/maps/public/layers/sources/es_search_source/update_source_editor.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/sources/es_search_source/es_search_source.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/sources/es_search_source/es_search_source.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/sources/es_search_source/update_source_editor.js
Outdated
Show resolved
Hide resolved
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
elastic#47361) * [Maps] Move sort out of top hits configuration for ES documents source * add migration script to convert topHitsTimeField to sortField * update i18n translations * add jest test for es docs source UpdateSourceEditor component * remove time configuration from top hits docs * update migrations integration expect statement * review feedback * reverse hits list so top documents by sort are drawn on top * update functional test expect to account for reversing hits order * update another functional test expect clause for reversing hits
#47361) (#47732) * [Maps] Move sort out of top hits configuration for ES documents source * add migration script to convert topHitsTimeField to sortField * update i18n translations * add jest test for es docs source UpdateSourceEditor component * remove time configuration from top hits docs * update migrations integration expect statement * review feedback * reverse hits list so top documents by sort are drawn on top * update functional test expect to account for reversing hits order * update another functional test expect clause for reversing hits
closes #46882 and #47279
This PR replaces
topHitsTimeFieldwithsortFieldandsortOrderand allows users to sort documents and top hit documents by any sortable field, including numbers