[Maps] Attribution for TMS/WMS are not showing

[thomasneirynck]

Attribution does not show on the map or in the layer-details.

Steps

1. add custom TMS (e.g. http://tile.thunderforest.com/cycle/{z}/{x}/{y}.png)
2. put in attribution

The app is not showing the attribution

• in the right-hand corner of the map
• in the source-details

Also, ideally attribution is editable in the layer-details. There's no UX for this.

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[thomasneirynck]

Seems related to this #44147

Is that PR functioning as it supposed to, or is there a regression? cc @aaronjcaldwell

[kindsun]

@thomasneirynck This is a regression. I'll look into it!

Also, ideally attribution is editable in the layer-details. There's no UX for this

Correct. This was the case for our existing attributions as well prior to the linked PR. I created this issue to track it: #44520

[kindsun]

@thomasneirynck I tested this locally for TMS entered in both the UI and via the config using your URL example and had attribution appear as expected for both. Can you double-check this issue locally? If you're still getting it, can you provide browser info and anything else that might help reproduce it?

[thomasneirynck]

Huh, ok 😴

I can see it in the right hand corner now. It's not showing in the source details. I'll update the description.

[kindsun]

@thomasneirynck I've looked at the source details for EMS as well as the newly added attribution details for WMS and TMS (configured and entered-via-ui), here's what they all look like in their current form:

EMS

Data source EMS Basemaps
Tile service Road map

Data source EMS Boundaries
Layer world_countries

TMS

Data source Tile Map Service
Url http://c.tile.stamen.com/watercolor/{z}/{x}/{y}.jpg

Data source Configured Tile Map Service
Tilemap url http://tile.thunderforest.com/cycle/{z}/{x}/{y}.png

WMS

Data source Web Map Service
Url https://www.gebco.net/data_and_products/gebco_web_services/web_map_service/mapserv?
Layers GEBCO_LATEST_2
Styles

It looks like we aren't showing the attribution text in the latest additions, but we weren't showing that for EMS either. Would you like me to revise TMS and WMS to look more like one of the EMS entries or something different since it's custom?

[thomasneirynck]

That's true, but for EMS we have the link to the landing page, which includes all relevant metadata.

In retrospect, if we have #44520 (which is more important imo), this issue (showing in source details) will be no longer relevant.

[kindsun]

Sounds good. Closing for now in favor of #44520