Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chromeless applications to render via non-/app routes #49102

Closed
3 tasks done
eliperelman opened this issue Oct 23, 2019 · 3 comments
Closed
3 tasks done

Allow chromeless applications to render via non-/app routes #49102

eliperelman opened this issue Oct 23, 2019 · 3 comments
Assignees
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.6.0 v8.0.0

Comments

@eliperelman
Copy link
Contributor

eliperelman commented Oct 23, 2019

In order for an application to be chromeless, we need the ability to render that application via a route that may not start with /app.

  • Make non-/app apps routable on the frontend
  • Modify backend to allow rendering Kibana from non-/app route
  • Explore implementation of a backend API that plugins can use to render the bundle for a specific application

Blocks #41981.

@eliperelman eliperelman added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform v8.0.0 v7.6.0 labels Oct 23, 2019
@eliperelman eliperelman self-assigned this Oct 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@eliperelman eliperelman added this to Prioritized Backlog in kibana-core [DEPRECATED] Oct 23, 2019
@joshdover
Copy link
Contributor

This part will definitely be tricky due to the integration with the legacy code that we still have to support for now.

One suggestion I have is to maybe avoid replacing the legacy ui_render_mixin.js and instead duplicate the necessary parts for the time being, just so we can support something like:

router.get({ path: '/login' }, (context) => context.application.renderEntryPoint())

This way you can leave the default /app/* handling in Legacy, and avoid moving this to NP and providing some bridge for the legacy details that are still needed. It will mean some code duplication though, so we should explore doing it "the right way" first, but maybe timebox it so we don't lose too much time on making that work seeing how it will be removed completely pretty soon.

@eliperelman eliperelman changed the title Allow registered standalone applications to render via non-/app routes Allow chromeless applications to render via non-/app routes Nov 6, 2019
@eliperelman eliperelman moved this from Prioritized Backlog to In progress in kibana-core [DEPRECATED] Nov 12, 2019
@pgayvallet
Copy link
Contributor

I think there might be a missing step?

  • Modify clientside appService / navlinkService to allow redirecting an app to a non /app/{appId} url ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.6.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

4 participants