-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new-platform] Add support for chromeless applications #41981
Comments
Pinging @elastic/kibana-platform |
Renamed this concept "Chromeless Applications". |
I don't think the issue is fully completed. There are several leftovers:
|
Wanted to follow-up on the notes left by @restrry to give a status update:
This is a nice-to-have, as the integration tests for this exist with the rendering service feature, but we want to move the test to a nicer location.
This is an outdated comment, no longer applicable.
This is true that this was covered by unit tests, but does not have an integration test. Josh and I discussed over Slack during development that we wouldn't do test variations based on all the options, but I don't think we intended for that to be here as well, so we can add another test here.
#54470: Fixing with #54768 |
I think we should go ahead and move this. Now that we have functional plugin tests and real NP plugins, I'd like to remove this testbed plugin completely. I don't think it's much work at all to move it over. The test itself should be a copy/paste. |
Are we going to address this? |
These tests were already existing, but we are removing a little tech debt by moving this to |
I don't think that test already existing #54768 (comment)
|
@eliperelman can you respond to Mikhail's latest comment? |
The work for completing chromeless applications is complete, and the remaining testing improvements are being captured in #55405. |
We need to add support for rendering "chromeless" frontend applications such as Login & Logout pages, session expiration, status page, dashboard mode, etc.
Things chromeless apps need to be able to do:
/app
prefix/app/{appId}
route in the app_render_mixin. We will need to be able to support other routes, so we may need to include a backend API that plugins can use to render the NP bundle for a specific app. The legacy platform has a similar API:h.renderApp
.For reference, In the legacy platform we called these "hidden applications."
Related to #18843
The text was updated successfully, but these errors were encountered: