Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-platform] Add support for chromeless applications #41981

Closed
joshdover opened this issue Jul 25, 2019 · 12 comments
Closed

[new-platform] Add support for chromeless applications #41981

joshdover opened this issue Jul 25, 2019 · 12 comments
Assignees
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

joshdover commented Jul 25, 2019

We need to add support for rendering "chromeless" frontend applications such as Login & Logout pages, session expiration, status page, dashboard mode, etc.

Things chromeless apps need to be able to do:

  • Option to hide Chrome UI when this app is mounted
  • No icon in the left navbar
  • Be able to live at URLs without the /app prefix
    • Currently the backend route that renders the NP is the /app/{appId} route in the app_render_mixin. We will need to be able to support other routes, so we may need to include a backend API that plugins can use to render the NP bundle for a specific app. The legacy platform has a similar API: h.renderApp.

For reference, In the legacy platform we called these "hidden applications."

Related to #18843

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jul 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@eliperelman
Copy link
Contributor

Renamed this concept "Chromeless Applications".

@eliperelman eliperelman moved this from In progress to Done (7.6) in kibana-core [DEPRECATED] Jan 9, 2020
@mshustov
Copy link
Contributor

mshustov commented Jan 10, 2020

I don't think the issue is fully completed. There are several leftovers:

@mshustov mshustov reopened this Jan 10, 2020
@mshustov mshustov moved this from Done (7.6) to In progress in kibana-core [DEPRECATED] Jan 10, 2020
@mshustov
Copy link
Contributor

Should be resolved as a part of the current issue, I suppose?
#54470
#54472

@eliperelman
Copy link
Contributor

eliperelman commented Jan 14, 2020

Wanted to follow-up on the notes left by @restrry to give a status update:

cleanup integration tests for rendering service #52161 (comment)

This is a nice-to-have, as the integration tests for this exist with the rendering service feature, but we want to move the test to a nicer location.

no integration tests for rendering service & csp config #51527 (comment)

This is an outdated comment, no longer applicable.

no integration tests for rendering service NP/LP apps, user settings includeUserSettings: true/false

This is true that this was covered by unit tests, but does not have an integration test. Josh and I discussed over Slack during development that we wouldn't do test variations based on all the options, but I don't think we intended for that to be here as well, so we can add another test here.

no integration tests for a user landing on a chromeless app page, navigating to a chromeless app from NP/LP apps

rendering service API & chromeless apps are not documented in the migration guide

#54744

Should be resolved as a part of the current issue, I suppose?

#54470: Fixing with #54768
#54472: This is related to the client rendering service, not the server rendering service, so was an existing bug. Fixed with #54550 by Pierre

@joshdover
Copy link
Contributor Author

This is a nice-to-have, as the integration tests for this exist with the rendering service feature, but we want to move the test to a nicer location.

I think we should go ahead and move this. Now that we have functional plugin tests and real NP plugins, I'd like to remove this testbed plugin completely. I don't think it's much work at all to move it over. The test itself should be a copy/paste.

@jinmu03
Copy link
Contributor

jinmu03 commented Jan 15, 2020

no integration tests for a user landing on a chromeless app page, navigating to a chromeless app from NP/LP apps

Are we going to address this?

@eliperelman
Copy link
Contributor

Are we going to address this?

These tests were already existing, but we are removing a little tech debt by moving this to plugin_functional in #54768.

@mshustov
Copy link
Contributor

These tests were already existing, but we are removing a little tech debt by moving this to plugin_functional in #54768.

I don't think that test already existing #54768 (comment)
Also not tested yet:

  • navigating to a chromeless app from NP app
  • navigating to a chromeless app from NP app

@jinmu03
Copy link
Contributor

jinmu03 commented Jan 17, 2020

@eliperelman can you respond to Mikhail's latest comment?

@eliperelman
Copy link
Contributor

@eliperelman
Copy link
Contributor

The work for completing chromeless applications is complete, and the remaining testing improvements are being captured in #55405.

kibana-core [DEPRECATED] automation moved this from In progress to Done (7.7) Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
Development

No branches or pull requests

5 participants