Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Route changes on telemetry submit #49263

Closed
justinkambic opened this issue Oct 24, 2019 · 3 comments · Fixed by #49671
Closed

[Uptime] Route changes on telemetry submit #49263

justinkambic opened this issue Oct 24, 2019 · 3 comments · Fixed by #49671
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.5.0 v7.6.0 v8.0.0

Comments

@justinkambic
Copy link
Contributor

justinkambic commented Oct 24, 2019

Kibana version:
7.5/master

Elasticsearch version:
8.x

Server OS version:
macOS

Browser version:
Chrome 77

Browser OS version:
macOS

Original install method (e.g. download page, yum, from source, etc.):
from source

Describe the bug:
The route changes from the given monitor page to the home page when the app autorefreshes

Steps to reproduce:

  1. Load the Uptime UI
  2. Navigate to the monitor page
  3. Wait for it to autorefresh
  4. See the updated route

Expected behavior:
The route won't be modified on refresh

Screenshots (if relevant):
image

Errors in browser console (if relevant):
N/A

Provide logs and/or server output (if relevant):
N/A

Any additional context:
This is almost definitely a React Router issue resulting from #47218.
Read the comment below for more info about some introduction to the causes.

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.5.0 v7.6.0 labels Oct 24, 2019
@justinkambic justinkambic self-assigned this Oct 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic
Copy link
Contributor Author

This seems to be related to the useTrackPageView hook imported from Infra. It's having some unforeseen side effect where it modifies the location without updating our router's history. It leads to some confusing route/history glitches with our app's navigation. We'll have to either modify our routing infrastructure or contribute some parameter to the hook to avoid causing this.

I'm going to have to investigate this further, but I think for now a valid alternative is to remove the reference to this hook and utilize the existing telemetry tracking that we had before it was added. Our telemetry collection shouldn't run the risk of making the user have a bad time.

@justinkambic justinkambic changed the title [Uptime] Route changes on update [Uptime] Route changes on telemetry submit Oct 29, 2019
@justinkambic
Copy link
Contributor Author

Here's a visual illustration of the issue:
Oct-29-2019 11-56-48

@zube zube bot added the [zube]: Done label Oct 31, 2019
@zube zube bot reopened this Oct 31, 2019
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 31, 2019
@zube zube bot closed this as completed Oct 31, 2019
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 31, 2019
@zube zube bot reopened this Oct 31, 2019
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 31, 2019
@zube zube bot closed this as completed Oct 31, 2019
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 31, 2019
@zube zube bot reopened this Oct 31, 2019
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 31, 2019
@zube zube bot closed this as completed Oct 31, 2019
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 31, 2019
@zube zube bot reopened this Oct 31, 2019
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 31, 2019
@zube zube bot closed this as completed Oct 31, 2019
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 31, 2019
@shahzad31 shahzad31 added test-plan test-plan-ok issue has passed test plan labels Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants