Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Global refresh button re-enables before map finishes loading #49510

Closed
spong opened this issue Oct 28, 2019 · 5 comments
Closed

[SIEM] Global refresh button re-enables before map finishes loading #49510

spong opened this issue Oct 28, 2019 · 5 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@spong
Copy link
Member

spong commented Oct 28, 2019

As shown below, when clicking the global Refresh button, the button does not take into account the map's loading state for when it should re-enable. Currently it stays in the Updating state until all the tables/KPI's finish loading, but not the map.

This wasn't initially implemented as there was no hook from the Maps/Embeddables API for knowing when the map had finished loading, and so we opened a feature request (#43695). Additionally, there was a need for knowing the number of features each layer has (#49236), and as part of that issue, we get a freebie and can now know when layers are done loading.

The maps teams has a draft PR up for this here: #49373

global_refresh_map_refresh

@spong spong added bug Fixes for quality problems that affect the customer experience Team:SIEM labels Oct 28, 2019
@spong spong self-assigned this Oct 28, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@spong
Copy link
Member Author

spong commented Jun 25, 2020

@MadameSheema this behavior is still present on 7.9.0-snapshot.

@MadameSheema MadameSheema added the Team:Threat Hunting Security Solution Threat Hunting Team label Oct 1, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
@MadameSheema MadameSheema added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Oct 30, 2020
@MindyRS
Copy link

MindyRS commented Nov 9, 2020

After giving this issue the 'Oldest Bug Award', Garret responded with this information. "this is technically still an outstanding UX issue, but it doesn't impact the user's day-to-day workflow, whereas the fix technically could impact them such as scenarios where they want to update the daterange or refresh the query, but the map is stuck in a loading state and thus has taken over the global refresh button and left it in a disabled state"

This bug has been officially refreshed!

@MindyRS
Copy link

MindyRS commented Nov 16, 2020

Upon further discussion, we're going to close this one out. "does it have a chance of ever being fixed? I would say maybe? But to be honest, at this point I'd probably just close it out as it doesn't seem to be worth the effort of tinkering with it, and users haven't reported any issues with understanding that the map is still loading since it has its own dedicated loader"

@MindyRS
Copy link

MindyRS commented Nov 16, 2020

Closing per @spong suggestion.

@MindyRS MindyRS closed this as completed Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants