Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Check hooks for exhaustive deps, remove linting exception #49564

Closed
spalger opened this issue Oct 28, 2019 · 4 comments · Fixed by #70010
Closed

[Lens] Check hooks for exhaustive deps, remove linting exception #49564

spalger opened this issue Oct 28, 2019 · 4 comments · Fixed by #70010
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019

In order to move forward with #49244 we needed to disable some rules in x-pack/legacy/plugins/lens. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['x-pack/legacy/plugins/lens/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/exhaustive-deps': 'off',
    'react-hooks/rules-of-hooks': 'off',
  },
},
@spalger spalger added the chore label Oct 28, 2019
@timroes timroes added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes
Copy link
Contributor

timroes commented Nov 18, 2019

cc @chrisdavies @wylieconlon

@wylieconlon
Copy link
Contributor

This issue is too big for fix it week. It's a large architectural effort.

@timroes timroes added the technical debt Improvement of the software architecture and operational architecture label Feb 21, 2020
@timroes timroes mentioned this issue Feb 21, 2020
6 tasks
@mbondyra mbondyra assigned mbondyra and unassigned mbondyra Apr 2, 2020
@wylieconlon
Copy link
Contributor

Hook rules are now being used. Exhaustive deps is next.

@wylieconlon wylieconlon changed the title Remove temporary x-pack/legacy/plugins/lens eslint overrides [Lens] Check hooks for exhaustive deps, remove linting exception Jun 18, 2020
@mbondyra mbondyra self-assigned this Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants