Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary x-pack/legacy/plugins/transform eslint overrides #49568

Closed
spalger opened this issue Oct 28, 2019 · 1 comment · Fixed by #49734
Closed

Remove temporary x-pack/legacy/plugins/transform eslint overrides #49568

spalger opened this issue Oct 28, 2019 · 1 comment · Fixed by #49734
Assignees
@walterra
Labels
chore Feature:Transforms ML transforms :ml v7.6.0

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019 •
edited
Loading

In order to move forward with #49244 we needed to disable some rules in x-pack/legacy/plugins/transform. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['x-pack/legacy/plugins/transform/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/exhaustive-deps': 'off',
  },
},
@spalger spalger added the chore label Oct 28, 2019
@spalger spalger mentioned this issue Oct 28, 2019
Open
31 tasks
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra self-assigned this Oct 30, 2019
@walterra walterra mentioned this issue Oct 30, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walterra walterra

Labels
chore Feature:Transforms ML transforms :ml v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Transforms: Removes temporary x-pack/legacy/plugins/transform eslint overrides. walterra/kibana
3 participants
@walterra @spalger @elasticmachine