Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NP migration: Url shortener service #50775

Closed
flash1293 opened this issue Nov 15, 2019 · 4 comments
Closed

NP migration: Url shortener service #50775

flash1293 opened this issue Nov 15, 2019 · 4 comments
Labels
Feature:NP Migration Feature:SharingURLs Short URLs and Share URL features Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
Kibana-app-np-migration

Comments

@flash1293
Copy link
Contributor

flash1293 commented Nov 15, 2019 •
edited
Loading

The url shortening service providing routes for creating new short urls (a type of saved objects) and for navigating to a shortened URL has to be migrated to the Kibana platform.

Currently located in src/legacy/server/url_shortening.

This service should be moved to the newly created share plugin which also houses the UI for short urls.

Used apis:

  • getHiddenUiAppById mixin (probably a blocker)
  • renderApp
  • Boom error
  • saved objects client
  • URL redirect
  • uiSettings
  • req.getBasePath
@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:SharingURLs Short URLs and Share URL features Feature:NP Migration labels Nov 15, 2019
@flash1293 flash1293 added this to To do in Kibana-app-np-migration via automation Nov 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mshustov mshustov mentioned this issue Nov 15, 2019
Closed
@flash1293
Copy link
Contributor Author

@restrry Looks like it makes sense to shim this service first, right? Are the other things besides getHiddenUiAppById already available?

@rudolf
Copy link
Contributor

rudolf commented Nov 15, 2019

In the NP we refer to "hidden apps" as "chromeless applications" #41981

@mshustov
Copy link
Contributor

mshustov commented Nov 18, 2019 •
edited
Loading

Discussed getHiddenUiAppById offline with @flash1293
Added recommended workarounds to #41964 (comment)

@flash1293 flash1293 mentioned this issue Nov 18, 2019
Merged
@flash1293 flash1293 moved this from To do to In progress in Kibana-app-np-migration Dec 4, 2019
@flash1293 flash1293 moved this from In progress to Done in Kibana-app-np-migration Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:NP Migration Feature:SharingURLs Short URLs and Share URL features Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
Kibana-app-np-migration
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rudolf @flash1293 @mshustov @elasticmachine