Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search.aggs] Support string statistics aggs in AggConfigs #51510

Closed
10 tasks
wylieconlon opened this issue Nov 22, 2019 · 5 comments
Closed
10 tasks

[data.search.aggs] Support string statistics aggs in AggConfigs #51510

wylieconlon opened this issue Nov 22, 2019 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@wylieconlon
Copy link
Contributor

wylieconlon commented Nov 22, 2019

On the ES side this was recently merged: elastic/elasticsearch#47468

a new metric aggregation called string_stats that operates on string terms of a document and returns the following:

min_length: The length of the shortest term
max_length: The length of the longest term
avg_length: The average length of all terms
distribution: The probability distribution of all characters appearing in all terms
entropy: The total Shannon entropy value calculated for all terms

This could be integrated into the Kibana aggregation configs, similar to the std_deviation metric which is implemented using extended_stats.

Based on the docs for the new aggregation these are all numbers except the multi-value distribution, so any of these numbers except distribution could be used as a metric in a visualization.

  • add new agg type
    • create the agg type
    • export an interface for the agg type's params
    • update AggParamsMapping in types.ts
    • register agg type via agg_types.ts
    • unit tests
  • add agg type expression function
    • write the expression function
    • register expression function via agg_types.ts
    • unit tests

Part of #60126

@wylieconlon wylieconlon added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes
Copy link
Contributor

timroes commented Dec 2, 2019

@wylieconlon Do we have a use-case for that in Lens right now? So does it make sense adding it to AggConfigs already without adding vis editor config, or do you suggest we're also adding this directly to an editor (like the old vis editor) to the user to configure?

@wylieconlon
Copy link
Contributor Author

Two use cases I imagine:

  • This is an introspection feature like Cardinality and helps users understand the size and shape of their data. It makes sense to build it into vis editors.
  • Metadata for determining if a keyword is something we want to recommend- super-long keywords are not good for visualizing. This does not require the agg config

@lukeelmers lukeelmers changed the title [Agg configs] Support string statistics aggregations [data.search.aggs] Support string statistics aggs in AggConfigs May 26, 2020
@lukeelmers lukeelmers added enhancement New value added to drive a business result Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers added this to To triage in kibana-app-arch via automation May 26, 2020
@lukeelmers lukeelmers moved this from To triage to Medium Horizon in kibana-app-arch May 26, 2020
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@ppisljar
Copy link
Member

ppisljar commented Aug 8, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as completed Aug 8, 2022
kibana-app-arch automation moved this from Medium Horizon to Done in current release Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
kibana-app-arch
  
Done in current release
Development

No branches or pull requests

5 participants