Miscellaneous App / Arch items 👉 New Platform

[lukeelmers]

Part of #31968

So far, the bulk of the code we have focused on migrating to the new platform either lives as a plugin or as a ui/public module. However, there are a handful of pieces such as utilities and one-off server endpoints which will also need to be migrated.

The purpose of this meta issue is to track these miscellaneous, "smaller" items that @elastic/kibana-app-arch will need to migrate to the new platform. This ensures we have a comprehensive list of everything we are aware of that needs to be reviewed.

src/legacy/ui/public

• utils/ @lukeelmers @alexwizp [3]
  • base_object -> unused; delete [ui/public/utils] Delete unused base_object & find_by_param #51854
  • case_conversion -> used by management, status. copy to each. [ui/public/utils] Copy rarely used items to where they are consumed #52841
  • cidr_mask -> agg types [ui/public/utils] Move items into agg_types  #51855
  • collection -> tracked by app team in Kibana app migration: Move static code dependencies into kibana_legacy plugin #50670
  • date_range -> agg types (and update import from pipeline helper) [ui/public/utils] Move items into agg_types  #51855
  • decode_geo_hash -> ui/vis [ui/public/utils] Move items into ui/vis #51856
  • diff_object -> state management (or leave behind) [ui/public/utils] Copy rarely used items to where they are consumed #52841
  • find_by_param -> delete. unused. [ui/public/utils] Delete unused base_object & find_by_param #51854
  • function -> used by state management & watch multi directives. copy to each. [ui/public/utils] Copy rarely used items to where they are consumed #52841
  • geo_utils -> agg_types [ui/public/utils] Move items into agg_types  #51855
  • ip_range -> agg_types & visualize loader. [ui/public/utils] Move items into agg_types  #51855
  • key_map -> saved object finder directive. [ui/public/utils] Copy rarely used items to where they are consumed #52841
  • legacy_class -> leave behind. apps using it will need to migrate away or copy.
  • math -> vis editor config, vislib. copy to each. [ui/public/utils] Copy rarely used items to where they are consumed #52841
  • migrate_legacy_query -> app team handling in Kibana app migration: Move static code dependencies into kibana_legacy plugin #50670
  • numeric -> management [ui/public/utils] Copy rarely used items to where they are consumed #52841
  • ordinal_suffix -> agg_types [ui/public/utils] Move items into agg_types  #51855
  • parse_interval -> tsvb & time_buckets. copy to data/common [ui/public/utils] Copy rarely used items to where they are consumed #52841
  • query_string -> kibana_utils/url, used by siem, ml, reporting, infra, state management [ui/utils/query_string]: Remove unused methods & migrate apps to querystring lib #56704
  • range -> default vis editor [ui/public/utils] Move items into ui/vis #51856
  • simple_emitter -> app team handling in Kibana app migration: Move static code dependencies into kibana_legacy plugin #50670
  • sort_prefix_first -> kuery autocomplete [ui/public/utils] Copy rarely used items to where they are consumed #52841
  • string_utils -> used in kibana management & SO loader. [ui/public/utils] Copy rarely used items to where they are consumed #52841
  • subscribe_with_scope -> leave behind, deprecated
  • supports -> tile map [ui/public/utils] Copy rarely used items to where they are consumed #52841
  • zoom_to_precision -> ui/vis/map [ui/public/utils] Move items into ui/vis #51856
• ui/public directories that are "done" and will get left behind and/or removed once apps have migrated (nothing specific for us to do here other than help ensure others aren't inadvertantly relying on them)
  • ui/indexed_array
  • ui/management
  • ui/filter_manager
  • ui/timefilter
  • ui/render_complete
  • ui/kbn_top_nav
  • ui/persisted_state
  • ui/registry
  • ui/state_management
  • ui/url

src/legacy/server

• remove index_patterns Move src/legacy/server/index_patterns to data plugin (server) #44190 @alexwizp

src/legacy/core_plugins

• Miscellaneous server items
  • suggestion values -> data value suggestions server route -> data plugin #52842
• embeddable_api -> delete Delete legacy embeddable_api plugin #61545

x-pack/legacy/plugins [3]

• kuery_autocomplete
  • Shim
  • Convert to TS / Jest tests kuery_autocomplete -> convert remaining items to TS/Jest #55487
  • Move to x-pack/plugins Move kuery_autocomplete ⇒ NP #51277

Other Tasks

• fieldFormatServiceFactory / FieldFormats exposed on server Expose NP FieldFormats service to server side #54571 @alexwizp
• Test plugins in test/plugin_functional Migrate test plugins ⇒ NP #51275 [3] @alexwizp
• [ ] [Breaking] Update IDs on plugins migrated to the new platform [Breaking] Update IDs on plugins migrated to the new platform #41931 No longer needed for App Arch plugins

Blocked items
These are items which are currently blocked by other work and may need to happen later in 7.x

• Migrations [App Arch] Saved object migrations from kibana plugin to new platform #55946 (blocked on Platform [Platform] SavedObject Migrations #50311) [1] @alexwizp
• Mappings (blocked on Platform [Platform] SavedObject Mappings #50309) [1]
• Migrate CSS to new platform [App Arch] migrate legacy CSS to new platform #55493 (blocked by Operations, Build New Platform Plugins #53532) [1] @alexwizp

[jasonrhodes]

As far as I can tell, QueryString.encode is identical to querystring.stringify and QueryString.decode the same as querystring.parse, using the querystring lib that we already import in Kibana (we were using it in APM, at least). I've switched the infra (metrics/logs) usages of these functions over to querystring and haven't had problems yet. If others need to be unblocked on that util import, that's one option.

[flash1293]

@lukeelmers Not sure whether this is the right place, but src/legacy/ui/public/visualize/loader/pipeline_helpers/utilities.ts is currently referenced by Lens. We should think about how to expose it in the future.

[lukeelmers]

@jasonrhodes Thanks for the tip on querystring. We will try updating uses of the legacy QueryString across Kibana and see how it goes. Tracking that in #56704

@flash1293 I think @ppisljar had planned on moving that into the visualizations or expressions plugins, but he'd be able to confirm.