Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Fix Moment Local change effecting other parts of the app #55176

Closed
shahzad31 opened this issue Jan 17, 2020 · 1 comment · Fixed by #55177
Closed

[Uptime] Fix Moment Local change effecting other parts of the app #55176

shahzad31 opened this issue Jan 17, 2020 · 1 comment · Fixed by #55177
Assignees
@andrewvc
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.6.0 v8.0.0

Comments

@shahzad31
Copy link
Contributor

shahzad31 commented Jan 17, 2020 •
edited
Loading

On details page we modified moment local to shorten relative time strings for Location Status Tags.

This is also effecting other parts of the application. We need to make local change localized.

So that it remains local only to Location Status Tags Component.

For example it's effecting SSL Certificate Component Date.
@shahzad31 shahzad31 self-assigned this Jan 17, 2020
@shahzad31 shahzad31 mentioned this issue Jan 17, 2020
Merged
7 tasks
@shahzad31 shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jan 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 assigned shahzad31 and unassigned shahzad31 Jan 20, 2020
@shahzad31 shahzad31 removed their assignment Jan 24, 2020
@andrewvc andrewvc self-assigned this Jan 24, 2020
@andrewvc andrewvc added the test-plan-ok issue has passed test plan label Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewvc andrewvc

Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Uptime] Update Moment Locale to keep it localized to the component shahzad31/kibana
3 participants
@andrewvc @shahzad31 @elasticmachine