Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a kbn-version header instead of kbn-xsrf-token #5594

Closed
spalger opened this issue Dec 8, 2015 · 0 comments
Closed

Send a kbn-version header instead of kbn-xsrf-token #5594

spalger opened this issue Dec 8, 2015 · 0 comments

Comments

@spalger
Copy link
Contributor

spalger commented Dec 8, 2015

The current implementation of the XSRF token causes the front-end to require a refresh any time the backend restarts. This can be avoided by setting the XSRF token explicitly, but it has been identified as a common occurrence in the wild that users randomly end up with broken Kibanas. This issue is worsened by the lack of any unified error handling that tells the user they need to refresh the browser. Depending on what you are doing an error is either shown at the top of the screen or shown modally as a fatal error.

For now we should simply change the mechanisms that send the kbn-xsrf-token header with each request to send the kibana version instead. We should also implement #5574 which details how we should check this header to protect against XSRF.
#5573 talks about the new UI to inform users when there is a mismatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant