Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: old panel still present after it was replaced with the new one #55992

Closed
dmlemeshko opened this issue Jan 27, 2020 · 3 comments · Fixed by #57093
Closed

Dashboard: old panel still present after it was replaced with the new one #55992

dmlemeshko opened this issue Jan 27, 2020 · 3 comments · Fixed by #57093
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dmlemeshko
Copy link
Member

dmlemeshko commented Jan 27, 2020

Kibana version: master

Elasticsearch version:

Server OS version: Linux (Jenkins CI workers)

Browser version: Chrome 79

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.): build on CI

Describe the bug: Dashboard: old panel still present after it was replaced with the new one

Steps to reproduce:
So far it is daily spotted on our CI: 1 failure on master per day starting Jan 21. Cannot reproduce locally

  1. Create a new dashboard, add 2 panels
  2. Click panel options button, click Replace panel
  3. Select one panel in the list
  4. Check the number of panels
    Result: 3 panels are present, replaced one is is still there

Expected behavior: old panel is not present

Screenshots (if relevant):

jobs:elastic+kibana+code-coverage:224:kibana-oss-t

Errors in browser console (if relevant):

http://localhost:6141/bundles/commons.bundle.js 63187:18 "Detected an unhandled Promise rejection.
TypeError: Cannot assign to read only property 'w' of object '#\u003CObject>'"
http://localhost:6141/bundles/plugin/dashboard_embeddable_container.bundle.js 3181:50 Uncaught TypeError: Cannot assign to read only property 'w' of object '#<Object>'

Provide logs and/or server output (if relevant):

Any additional context:

kbn  Failing Tests - Kibana 2020-01-27 13-32-50

FAILURE test/functional/apps/dashboard/panel_controls·js dashboard app using legacy data dashboard panel controls visualization object replace flyout replaces old panel with selected panel

Error: expected 3 to equal 2
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:227:8)
    at Assertion.be (packages/kbn-expect/expect.js:69:22)
    at Context.it (test/functional/apps/dashboard/panel_controls.js:76:39)
    at process._tickCallback (internal/process/next_tick.js:68:7)
@dmlemeshko dmlemeshko added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

ping @Dosant was this perhaps caused by the app state migration?

@Dosant
Copy link
Contributor

Dosant commented Feb 7, 2020

This regressed in #54105 and should be implicitly fixed in #55158.

Unskipping the test in #57093

Just for info:

Cannot reproduce locally

When it was reproducable, I was able to reproduce locally, by forcing state to come from URL. e.g

  1. Create a new dashboard, add 2 panels
  2. Change position of one of the panels
  3. Undo it by browser's back button
  4. Click panel options button, click Replace panel
  5. Select one panel in the list
  6. Check the number of panels
  7. Result: 3 panels are present, replaced one is is still there

And that error is in console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants