Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest] Support agent config versioning #56750

Closed
4 tasks done
nchaulet opened this issue Feb 4, 2020 · 2 comments · Fixed by #60292
Closed
4 tasks done

[Ingest] Support agent config versioning #56750

nchaulet opened this issue Feb 4, 2020 · 2 comments · Fixed by #60292
Assignees
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@nchaulet
Copy link
Member

nchaulet commented Feb 4, 2020

Description

We should allow versioning of AgentConfigs.

The version should be visible in fleet UIs, and send to the agent during checkin, also agents could report the config version they are running when they checkin.

Data model update

We should use _version of saved object,
Every-time we modify a datasource we should upgrade AgentConfig _version

Edit: as of ES 7.0+, _version is no longer a simple incremented number. Therefore we should implement our own revision property as a custom saved object attribute.

API update

  • We should add a revision property to agent configs and datasources. When a datasource is created/updated/removed, its associated agent config revision should also be bumped. Done in [Ingest] Add revision to agent configs & data sources #59848
  • Add config_revision property to agents and make sure agent sends and update this information on ack of config change.

UI update

@nchaulet nchaulet added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project labels Feb 4, 2020
@nchaulet nchaulet self-assigned this Feb 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest (Feature:Fleet)

@nchaulet nchaulet removed their assignment Mar 2, 2020
@jen-huang
Copy link
Contributor

We should allow user to get older versions of agent, and datasources.

I would skip this for now as the _version prop that we get from saved objects for free is from the same ES property for all documents. However ES does not allow retrieval of previous versions.

@jen-huang jen-huang self-assigned this Mar 9, 2020
@jen-huang jen-huang changed the title [Fleet] AgentConfig versionning [Ingest] Support agent config versioning Mar 10, 2020
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants