Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Safari font render: Ligatures are rendered as normal, but it forces certain letters together #57445

Closed
formgeist opened this issue Feb 12, 2020 · 3 comments · Fixed by #57555
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

formgeist commented Feb 12, 2020

Kibana version: master
Safari: 13.0.4

Summary

Safari runs a different CSS prop for rendering ligatures in fonts, specifically in our Roboto Mono font that we use for a any code text copy in the UI.

Profiles is rendered with fi snapped together

Screenshot 2020-02-12 at 11 43 37

vs. how it should render Profiles

Screenshot 2020-02-12 at 11 52 30

If I add this CSS prop, it'll fix the issue (as shown above)

font-variant-ligatures: no-common-ligatures;

@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Feb 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

I couldn't find any mentions of Roboto Mono in the APM codebase. Is this something that should be fixed globally - perhaps by EUI?

@formgeist
Copy link
Contributor Author

@sqren I must've thought I saw that we had changed our variables to Roboto Mono to follow EUI, but we haven't (yet).

https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/apm/public/style/variables.ts#L34-L36

I think we could update our variables file at the very least to render Roboto Mono instead of San Francisco Mono, and then perhaps look at replacing our code font instances with possibly the EuiCodeFont variable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants