Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Update monospace font family variable #57555

Merged

Conversation

formgeist
Copy link
Contributor

Summary

Closes #57445

Updating the monospace font family used in various places in APM UI to match the EUI theme.

Screenshot 2020-02-13 at 13 02 28

Screenshot 2020-02-13 at 13 02 36

Screenshot 2020-02-13 at 13 02 43

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@formgeist formgeist added release_note:enhancement Team:APM All issues that need APM UI Team support v7.7.0 labels Feb 13, 2020
@formgeist formgeist requested a review from a team as a code owner February 13, 2020 12:04
@formgeist formgeist self-assigned this Feb 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@formgeist formgeist merged commit 5fe53d1 into elastic:master Feb 13, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 13, 2020
* master: (22 commits)
  skip flaky suite (elastic#50018)
  skip settings tests (elastic#57608)
  skip failing suite (elastic#44631)
  [SIEM] [Case] Initial UI (elastic#57283)
  handle viewing sample dashboards on default dist (elastic#57510)
  Fix detection of "system requests" in plugins (elastic#57149)
  [ML] New Platform server shim: update job service schema (elastic#57614)
  skip flaky suite (elastic#44631)
  [APM] Update monospace font family variable (elastic#57555)
  skip flaky test (elastic#57377)
  Skip save query tests (elastic#57589)
  [Maps] allow simultaneous opening of multiple tooltips (elastic#57226)
  [Uptime] Fix/host connected components (elastic#56969)
  [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254)
  [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403)
  [Maps] Fix document source top hits split by scripted field (elastic#57481)
  Use log4j pattern syntax (elastic#57433)
  [ML] Categorization field example endpoint tests (elastic#57471)
  [Lens] Filter out pinned filters from saved object of Lens (elastic#57197)
  Lens client side shim cleanup (elastic#56976)
  ...
@formgeist formgeist deleted the apm/fix-monospace-font-family-variable branch February 17, 2020 09:39
formgeist added a commit that referenced this pull request Feb 17, 2020
* [APM] Remove fontFamily variable (not in use)

* [APM] Update fontFamilyCode font family

* Update snapshots

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:APM All issues that need APM UI Team support v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Safari font render: Ligatures are rendered as normal, but it forces certain letters together
5 participants