Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested field support in Visualize #58175

Open
Tracked by #60126
Bargs opened this issue Feb 20, 2020 · 19 comments
Open
Tracked by #60126

Nested field support in Visualize #58175

Bargs opened this issue Feb 20, 2020 · 19 comments
Labels
enhancement New value added to drive a business result Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed

Comments

@Bargs
Copy link
Contributor

Bargs commented Feb 20, 2020

Part of #1084

Similar to querying, aggregating on nested fields requires users to make some choices depending on what info seek. Imagine doing a terms aggregation on a nested field with a simple "count" metric. For each bucket, do you want to count the number of nested documents that match, or the number of parent documents? We can do either one and both might be useful depending on the question you're trying to answer. The Visualize editor will need to give the user a choice in a way that is easy to understand.

For non-count metrics that require selecting a specific field, I think we can handle things in a way that's transparent to the user. By selecting a field, you're already implicitly telling us whether to do the aggregation at the parent or child level.

Nested fields come along with two special aggregations for working with them, nested and reverse_nested. We'll need to use both to fully support nested fields in Visualize. Except in the case of the "count" metric (as mentioned above), we should be able to generate the necessary nested and reverse_nested wrappers using nested field information in the index pattern. I think the trickiest bit of the implementation will be keeping track of the current level of nesting as we generate the aggregation DSL, because we don't currently have a precedent in the visualize code for child aggs that know anything about their parents.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@github-actions github-actions bot added this to To triage in kibana-app-arch Feb 20, 2020
@alexh97 alexh97 added the enhancement New value added to drive a business result label Mar 3, 2020
@alexh97 alexh97 moved this from To triage to Short Horizon in kibana-app-arch Mar 3, 2020
@lukeelmers lukeelmers added the Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) label Mar 5, 2020
@lukeelmers lukeelmers moved this from Short Horizon to Long Horizon in kibana-app-arch May 26, 2020
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@ppisljar
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
kibana-app-arch automation moved this from Long Horizon to Done in current release Aug 11, 2022
@a03nikki
Copy link

a03nikki commented Aug 30, 2022

Considering the support for nested data type was started with #1084 and that ticket is in progress, it would be nice if it would include the visualizations as well. I would think this would be a sub-task of finishing #1084.

@a03nikki a03nikki reopened this Aug 30, 2022
kibana-app-arch automation moved this from Done in current release to In progress Aug 30, 2022
@petrklapka petrklapka added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:AppServicesSv labels Nov 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@dej611
Copy link
Contributor

dej611 commented Jan 9, 2023

@jaGarcia
Copy link

jaGarcia commented Mar 1, 2023

+1 to supporting nested docs in Visualize

@sacalata
Copy link

+1 doesn't OpenSearch support this already?

@mgevans-5
Copy link

+1 we have some use cases for this feature too

@tom-allen
Copy link

+1 please reopen this. nested objects are very useful.

@shlomoksp
Copy link

shlomoksp commented Jul 4, 2023

+1

@Sagesh
Copy link

Sagesh commented Jul 20, 2023

+1 Reopen this isssue

@gemo1011
Copy link

+1

1 similar comment
@perceptivesecurity
Copy link

+1

@omar6995
Copy link

omar6995 commented Nov 5, 2023

+20

@carlopuri
Copy link

+2*10^10000

@carlopuri
Copy link

digging with Vega with poor support isn't a good solution for visualise nested values...

@pvcasillasg
Copy link

+1

1 similar comment
@ijardillier
Copy link

+1

@bosonno
Copy link

bosonno commented Jul 9, 2024

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed
Projects
kibana-app-arch
  
In progress
Development

No branches or pull requests