Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uiActions available via renderer handlers #61054

Closed
timroes opened this issue Mar 24, 2020 · 3 comments
Closed

Make uiActions available via renderer handlers #61054

timroes opened this issue Mar 24, 2020 · 3 comments
Labels
enhancement New value added to drive a business result Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:UIActions UI actions. These are client side only, not related to the server side actions..

Comments

@timroes
Copy link
Contributor

timroes commented Mar 24, 2020

As it came up in this comment we currently need to pass down uiActions through the whole plugin to get access to in an expression renderer (where it will most commonly needed in every renderer). Could we somehow give access to the executeTriggerActions function via the handlers passed to renderers?

This would prevent us from needing to use getterSetter in those places, since we need to register the renderer in the setup method (since that is where the expressions plugin exposes the registerRenderer function), and the executeTriggerActions is only available in the start phase. So we need to always work with the createGetterSetter approach. I think it would be benefitial for a lot of renderers, if we would just have access to executeTriggerActions via handlers.

cc @ppisljar @stacey-gammon

@timroes timroes added enhancement New value added to drive a business result Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch Feature:UIActions UI actions. These are client side only, not related to the server side actions.. labels Mar 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers
Copy link
Member

This would prevent us from needing to use getterSetter in those places

Could createGetterSetter instead be replaced with core.getStartServices() so that we don't need to throw something else in the handlers? Somewhat related to #61106

@timroes
Copy link
Contributor Author

timroes commented Mar 26, 2020

Yes I wasn't aware of that method, I would say that's indeed the better solution (implemented in #61421). Closing this issue.

@timroes timroes closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:UIActions UI actions. These are client side only, not related to the server side actions..
Projects
None yet
Development

No branches or pull requests

3 participants