Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive design on the PR checklist #61787

Open
timroes opened this issue Mar 30, 2020 · 0 comments
Open

Responsive design on the PR checklist #61787

timroes opened this issue Mar 30, 2020 · 0 comments
Labels

Comments

@timroes
Copy link
Contributor

timroes commented Mar 30, 2020

In #56756 we introduced a checkbox in the PR template to check for responsive design. I would like to put some more discussion around that checkbox and implications from it.

If we add something to the generic PR checklist it should be a general requirement for all PRs (where it technically makes sense, e.g. in this case, that have UI changes). Despite obviously having a responsive design would be a goal for Kibana I don't have the feeling we're there yet for a couple of reasons:

  • Large parts of Kibana are simply not responsive yet, and we'll need some larger time investment to get them there.
  • We're currently not designing around responsive design.

So I would want to put one of the following options up for discussion:

  • Either we remove the point of the checklist again, because having a point that most people will just remove from their PR again should not be the purpose of this checklist (which is actually also the original intention of the PR that introduced this).
  • or if we plan to actually have PRs been checked for their responsive design I suggest we talk about the following points:
    • Design should make responsive design mandatory, i.e. every design and mockup we're making should always be produced in at least 2 ideally 3 different variations (mobile, in-between [some might call that tablet], full size). So that when developing we know exactly how we want the responsive design to look, and we can make sure we're taking potential edge cases and how UI will scale into consideration while discussing those designs.
    • Start to plan some larger resources invested into getting existing UI into a more or less responsive state.
    • Start discussion around which features exactly we want to be responsive and which ones might be excluded (e.g. grid layout editing on dashboard), because they don't make sense and track those decicions.

cc tech leads @peterschretlen @stacey-gammon @kobelb
cc ppl involved in original PR @cchaos @lukeelmers @streamich @andrewvc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant