Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Copy for custom links is off #62432

Closed
dgieselaar opened this issue Apr 3, 2020 · 3 comments · Fixed by #62577
Closed

[APM] Copy for custom links is off #62432

dgieselaar opened this issue Apr 3, 2020 · 3 comments · Fixed by #62577
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Custom Links Team:APM All issues that need APM UI Team support v7.7.0

Comments

@dgieselaar
Copy link
Member

"These links will be shown in the 'Actions' context menu for the transaction detail." => "These links will be shown in the 'Actions' context menu for transactions."

image

"i.e." => "e.g."

image

TBC

@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Apr 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@bmorelli25
Copy link
Member

While fixing these, I wonder if it's not too late to change the title of this page as well.
Screen Shot 2020-04-03 at 9 12 05 AM

According to the product naming guide (internal link), Kibana apps, like the APM app, are not supposed to be called UIs. Would Customize app be better? Or even just Customize?

I don't think the single quotes are needed around actions. I think this is fine:

The links will be shown in the Actions context menu for transactions.

If we're going to stick with "e.g.", don't forget the commas before and after it. Something like:

No custom links found. Set up your own custom links, e.g., a link to a specific dashboard,
or an external link to a company website.

@cauemarcondes
Copy link
Contributor

cauemarcondes commented Apr 6, 2020

Would Customize app be better? Or even just Customize?

Changed it to Customize app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Custom Links Team:APM All issues that need APM UI Team support v7.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants