Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Close popover when open Custom Link flyout. #62577

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

cauemarcondes
Copy link
Contributor

fixes #62433
fixes #62432

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Feature:Custom Links labels Apr 6, 2020
@cauemarcondes cauemarcondes requested a review from a team as a code owner April 6, 2020 10:15
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes changed the title [APM] Closes popover when open Custom Link flyout. [APM] Close popover when open Custom Link flyout. Apr 6, 2020
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@cauemarcondes cauemarcondes merged commit 0458626 into elastic:master Apr 7, 2020
@cauemarcondes cauemarcondes deleted the custom-link-bugfix branch April 7, 2020 07:08
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Apr 7, 2020
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Apr 7, 2020
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Apr 7, 2020
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Apr 7, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 7, 2020
* master: (36 commits)
  [data.search.aggs] Remove service getters from agg types (elastic#61628)
  fixing APM internationalization (elastic#62757)
  fix: 🐛 correctly create error on no_matching_indices (elastic#61257)
  [Lens] Remove all legacy imports (elastic#62596)
  Add label for ace editor (elastic#62588)
  [ML] Show better file structure finder explanations (elastic#62316)
  Fix old pathes in eslintrc (elastic#62580)
  [Uptime] Improve Telemetry test (elastic#62428)
  [SIEM] Adds sort rules Cypress test (elastic#62700)
  [Uptime]Abstracted 'access:uptime-read' tag into a wrapper for… (elastic#62576)
  fixing bug (elastic#62577)
  [Maps] Allow updating requestType for ESGeoGridSource (elastic#62365)
  [Maps] do not show circle border when symbol size is zero (elastic#62644)
  [Maps] Always show current zoom level (elastic#62684)
  bc5 siem rules merge (elastic#62679)
  Revert "[Monitoring] Cluster state watch to Kibana alerting (elastic#61685)"
  Fix visual tests (elastic#62660)
  [Telemetry] update crypto packages (elastic#62469)
  [DOCS] Removed references to left (elastic#60807)
  [Maps] Move layers to np maps (elastic#61877)
  ...
cauemarcondes added a commit that referenced this pull request Apr 7, 2020
…2577) | fixing APM internationalization (#62757) (#62768)

* fixing bug (#62577)

* fixing APM internationalization (#62757)
cauemarcondes added a commit that referenced this pull request Apr 7, 2020
…2577) | fixing APM internationalization (#62757) (#62767)

* fixing bug (#62577)

* fixing APM internationalization (#62757)
@bmorelli25
Copy link
Member

Thanks @cauemarcondes, this looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Custom Links release_note:skip Skip the PR/issue when compiling release notes v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Actions menu doesn't close when opening Custom Links flyout [APM] Copy for custom links is off
4 participants