Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APM Inferred spans #62952

Closed
2 tasks done
cauemarcondes opened this issue Apr 8, 2020 · 6 comments · Fixed by #63695
Closed
2 tasks done

APM Inferred spans #62952

cauemarcondes opened this issue Apr 8, 2020 · 6 comments · Fixed by #63695
Assignees
Labels
Team:APM All issues that need APM UI Team support v7.8.0

Comments

@cauemarcondes
Copy link
Contributor

cauemarcondes commented Apr 8, 2020

  • Create mock data with inferred spans
  • Create storybook

for elastic/apm#247

@cauemarcondes cauemarcondes added [zube]: Inbox Team:APM All issues that need APM UI Team support v7.8.0 labels Apr 8, 2020
@cauemarcondes cauemarcondes self-assigned this Apr 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@felixbarny
Copy link
Member

We've caught some more edge cases in the Java agent which is why there's a bit of a delay.

Question: can the UI handle the case where a span has child_ids set which are not immediate children?

[1           ]
 [a         ]   <- has child_ids: [2, 3], even though only 2 is a direct child
  [b][2    ]
      [3  ]
       [c]

@cauemarcondes
Copy link
Contributor Author

Question: can the UI handle the case where a span has child_ids set which are not immediate children?

@felixbarny how can I differentiate ids 2 and 3?

@felixbarny
Copy link
Member

Not sure I understand what you mean. With child_ids: [2, 3] I mean that the span, which is denoted with a in the diagram, has two child ids: The id belonging to the spans denoted with 2 and 3. Where you might expect only one child id - the one of span 2.

@cauemarcondes
Copy link
Contributor Author

What I meant is if the span a has child.ids = [2, 3] but only the span 2 is the direct child of a, what's the logic that I should apply to not reparent the span 3?

@felixbarny
Copy link
Member

I've fixed it in the Java agent: elastic/apm-agent-java@5b4ff72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support v7.8.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants