Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest Manager: do not break UI on package issue #64067

Closed
mtojek opened this issue Apr 21, 2020 · 2 comments
Closed

Ingest Manager: do not break UI on package issue #64067

mtojek opened this issue Apr 21, 2020 · 2 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@mtojek
Copy link
Contributor

mtojek commented Apr 21, 2020

Accidentally I screwed up single file (Kibana map) in the package. The entire UI crashed with a JS error, preventing me from doing any action.

What do you think about skipping damaged integrations and let UI work without them? A nice-to-have feature would be also a top banner informing about a package problem.

@mtojek mtojek added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ruflin ruflin added bug Fixes for quality problems that affect the customer experience Ingest Management:beta1 labels Apr 21, 2020
@skh skh self-assigned this Apr 23, 2020
@ruflin ruflin added Ingest Management:alpha1 Group issues for ingest management alpha1 and removed Ingest Management:beta1 labels Apr 23, 2020
@skh
Copy link
Contributor

skh commented May 19, 2020

I'm moving this to beta 1. We need to be sure to catch errors during the installation of Kibana assets, but I was having a hard time triggering these errors from packages from a local package registry -- if I try to pass it broken JSON for example, the package registry would catch that during mage build (which is a good thing).

If you have a Kibana asset that is valid JSON and still causes errors, please add it here in a comment (in full).

@skh skh added Ingest Management:beta1 and removed Ingest Management:alpha1 Group issues for ingest management alpha1 labels May 19, 2020
@skh skh closed this as completed May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

4 participants