Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move apm tutorial from apm plugin into apm_oss plugin #65629

Closed
flash1293 opened this issue May 7, 2020 · 1 comment · Fixed by #66432
Closed

Move apm tutorial from apm plugin into apm_oss plugin #65629

flash1293 opened this issue May 7, 2020 · 1 comment · Fixed by #66432
Assignees
@DianaDerevyankina
Labels
Feature:Home Kibana home application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

The apm tutorial and related assets are currently located in the xpack apm plugin. This means there won't be an apm tutorial shown on the home page when using the OSS distribution.

To fix this problem, the tutorial and all used assets should be moved into apm_oss instead.
@flash1293 flash1293 added Feature:Home Kibana home application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue May 13, 2020
@DianaDerevyankina
Move apm tutorial from apm plugin into apm_oss plugin
286a45f 
Closes elastic#65629
@DianaDerevyankina DianaDerevyankina mentioned this issue May 13, 2020
Merged
7 tasks
DianaDerevyankina added a commit that referenced this issue May 20, 2020
@DianaDerevyankina
Move apm tutorial from apm plugin into apm_oss plugin (#66432)
27fe265 
* Move apm tutorial from apm plugin into apm_oss plugin

Closes #65629

* Fix types issues and some paths

* Add unregisterTutorial to tutorials_registry.mock

* Add apm path to .i18nrc.json to fix internationalization error

* Rename apm path in .i18nrc.json into apmOss and revert some imports paths
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue May 20, 2020
@DianaDerevyankina
Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432)
bfd0256 
* Move apm tutorial from apm plugin into apm_oss plugin

Closes elastic#65629

* Fix types issues and some paths

* Add unregisterTutorial to tutorials_registry.mock

* Add apm path to .i18nrc.json to fix internationalization error

* Rename apm path in .i18nrc.json into apmOss and revert some imports paths
# Conflicts:
#	x-pack/plugins/apm/server/tutorial/instructions/apm_agent_instructions.ts
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue May 21, 2020
@DianaDerevyankina
Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432)
6cd53d2 
* Move apm tutorial from apm plugin into apm_oss plugin

Closes elastic#65629

* Fix types issues and some paths

* Add unregisterTutorial to tutorials_registry.mock

* Add apm path to .i18nrc.json to fix internationalization error

* Rename apm path in .i18nrc.json into apmOss and revert some imports paths
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue May 21, 2020
@DianaDerevyankina
Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432)
f9624df 
* Move apm tutorial from apm plugin into apm_oss plugin

Closes elastic#65629

* Fix types issues and some paths

* Add unregisterTutorial to tutorials_registry.mock

* Add apm path to .i18nrc.json to fix internationalization error

* Rename apm path in .i18nrc.json into apmOss and revert some imports paths
# Conflicts:
#	x-pack/plugins/apm/server/tutorial/instructions/apm_agent_instructions.ts
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue May 21, 2020
@DianaDerevyankina
Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432)
a0ea7ee 
* Move apm tutorial from apm plugin into apm_oss plugin

Closes elastic#65629

* Fix types issues and some paths

* Add unregisterTutorial to tutorials_registry.mock

* Add apm path to .i18nrc.json to fix internationalization error

* Rename apm path in .i18nrc.json into apmOss and revert some imports paths
# Conflicts:
#	x-pack/plugins/apm/server/tutorial/instructions/apm_agent_instructions.ts
DianaDerevyankina added a commit that referenced this issue May 26, 2020
@DianaDerevyankina
[7.x] Move apm tutorial from apm plugin into apm_oss plugin (#66432) (#…
ce0e4f6 
…67179)

* Move apm tutorial from apm plugin into apm_oss plugin (#66432)

* Move apm tutorial from apm plugin into apm_oss plugin

Closes #65629

* Fix types issues and some paths

* Add unregisterTutorial to tutorials_registry.mock

* Add apm path to .i18nrc.json to fix internationalization error

* Rename apm path in .i18nrc.json into apmOss and revert some imports paths
# Conflicts:
#	x-pack/plugins/apm/server/tutorial/instructions/apm_agent_instructions.ts

* Fixed some eslint issues

* Fix apmOSSPluginSetupMock
@jalvz jalvz mentioned this issue May 27, 2020
Merged
10 tasks
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this issue May 28, 2020
@DianaDerevyankina
Move apm tutorial from apm plugin into apm_oss plugin (elastic#66432)
6309c97 
* Move apm tutorial from apm plugin into apm_oss plugin

Closes elastic#65629

* Fix types issues and some paths

* Add unregisterTutorial to tutorials_registry.mock

* Add apm path to .i18nrc.json to fix internationalization error

* Rename apm path in .i18nrc.json into apmOss and revert some imports paths
# Conflicts:
#	x-pack/plugins/apm/server/plugin.ts
#	x-pack/plugins/apm/server/tutorial/elastic_cloud.ts
#	x-pack/plugins/apm/server/tutorial/envs/on_prem.ts
#	x-pack/plugins/apm/server/tutorial/index.ts
#	x-pack/plugins/apm/server/tutorial/instructions/apm_agent_instructions.ts
#	x-pack/plugins/apm/server/tutorial/instructions/apm_server_instructions.ts
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
DianaDerevyankina added a commit that referenced this issue Jun 2, 2020
@DianaDerevyankina
[7.8] Move apm tutorial from apm plugin into apm_oss plugin (#66432) (#…
3fc974b 
…67619)

* Move apm tutorial from apm plugin into apm_oss plugin (#66432)

* Move apm tutorial from apm plugin into apm_oss plugin

Closes #65629

* Fix types issues and some paths

* Add unregisterTutorial to tutorials_registry.mock

* Add apm path to .i18nrc.json to fix internationalization error

* Rename apm path in .i18nrc.json into apmOss and revert some imports paths
# Conflicts:
#	x-pack/plugins/apm/server/plugin.ts
#	x-pack/plugins/apm/server/tutorial/elastic_cloud.ts
#	x-pack/plugins/apm/server/tutorial/envs/on_prem.ts
#	x-pack/plugins/apm/server/tutorial/index.ts
#	x-pack/plugins/apm/server/tutorial/instructions/apm_agent_instructions.ts
#	x-pack/plugins/apm/server/tutorial/instructions/apm_server_instructions.ts
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json

* Fix issues produced by mistake through merge conflict

* Fix some eslint issues

* Fix type check

* Remove unused translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DianaDerevyankina DianaDerevyankina

Labels
Feature:Home Kibana home application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move apm tutorial from apm plugin into apm_oss plugin DianaDerevyankina/kibana
3 participants
@flash1293 @elasticmachine @DianaDerevyankina