Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Option to disable interactions #65630

Closed
flash1293 opened this issue May 7, 2020 · 3 comments · Fixed by #83559
Closed

[Lens] Option to disable interactions #65630

flash1293 opened this issue May 7, 2020 · 3 comments · Fixed by #83559
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@flash1293
Copy link
Contributor

In the current state Lens charts (like the xy chart or the table) will always offer interactivity (e.g. brushing a range on the x axis, clicking a bar or using +/- buttons in table cells).

In some contexts this is not desired, for example when using a lens vis in canvas.

In this case the embeddable input option disableTriggers is set to true. This information could be passed to the renderer via a variable, making it also usable from within the expression for later use cases.

@kibanamachine kibanamachine added this to Long-term goals in Lens May 7, 2020
@timroes timroes added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

@flash1293 I was a bit confused by the description, because we don't actually trigger any actions when disableTriggers is set to true. But I think your are referring to the same issue that @cqliu1 has previously talked about: it looks like you can interact with Lens, even though it has no effect. disableTriggers should completely prevent the interactions that would normally take place, for example not showing a grabby cursor or drag handles.

@wylieconlon
Copy link
Contributor

@cqliu1 Do you think this issue is still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants