Expression: Add render mode and use it for canvas interactivity #83559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Lens
release_note:skip
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
added
Team:AppArch
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
botelastic
bot
added
the
Feature:ExpressionLanguage
clintandrewhall
approved these changes
Nov 18, 2020
| @@ -92,6 +93,9 @@ export class ExpressionRenderHandler { | |||
| event: (data) => { | |||
| this.eventsSubject.next(data); | |||
| }, | |||
| getMode: () => { | |||
There was a problem hiding this comment.
nit: I'd prefer consistency.
Suggested change
| getMode: () => { | |
| getRenderMode: () => { |
| // Warning: (ae-forgotten-export) The symbol "RenderMode" needs to be exported by the entry point index.d.ts | ||
| // | ||
| // (undocumented) | ||
| getMode: () => RenderMode; |
There was a problem hiding this comment.
Suggested change
| getMode: () => RenderMode; | |
| getRenderMode: () => RenderMode; |
| @@ -11,6 +11,7 @@ export const defaultHandlers: RendererHandlers = { | |||
| destroy: () => action('destroy'), | |||
| getElementId: () => 'element-id', | |||
| getFilter: () => 'filter', | |||
| getMode: () => 'display', | |||
There was a problem hiding this comment.
Suggested change
| getMode: () => 'display', | |
| getRenderMode: () => 'display', |
| @@ -23,6 +23,9 @@ export const createHandlers = (): RendererHandlers => ({ | |||
| getFilter() { | |||
| return ''; | |||
| }, | |||
| getMode() { | |||
There was a problem hiding this comment.
Suggested change
| getMode() { | |
| getRenderMode() { |
| @@ -139,6 +139,7 @@ export const getPieRenderer = (dependencies: { | |||
| chartsThemeService={dependencies.chartsThemeService} | |||
| paletteService={dependencies.paletteService} | |||
| onClickValue={onClickValue} | |||
| renderMode={handlers.getMode()} | |||
There was a problem hiding this comment.
Suggested change
| renderMode={handlers.getMode()} | |
| renderMode={handlers.getRenderMode()} |
| @@ -212,6 +216,7 @@ export const getXyChartRenderer = (dependencies: { | |||
| histogramBarTarget={dependencies.histogramBarTarget} | |||
| onClickValue={onClickValue} | |||
| onSelectRange={onSelectRange} | |||
| renderMode={handlers.getMode()} | |||
There was a problem hiding this comment.
Suggested change
| renderMode={handlers.getMode()} | |
| renderMode={handlers.getRenderMode()} |
|
Fair point @clintandrewhall , I changed it to "getRenderMode" |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
dej611
approved these changes
Nov 24, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Nov 24, 2020
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Nov 24, 2020
* master: (41 commits) [Maps] fix code-owners (elastic#84265) [@kbn/utils] Clean target before build (elastic#84253) [code coverage] collect for oss integration tests (elastic#83907) [APM] Use `asTransactionRate` consistently everywhere (elastic#84213) Attempt to fix incremental build error (elastic#84152) Unskip "Copy dashboards to space" (elastic#84115) Remove expressions.legacy from README (elastic#79681) Expression: Add render mode and use it for canvas interactivity (elastic#83559) [deb/rpm] Move systemd service to /usr/lib/systemd/system (elastic#83571) [Security Solution][Resolver] Allow a configurable entity_id field (elastic#81679) [ML] Space permision checks for job deletion (elastic#83871) [build] Provide ARM build of RE2 (elastic#84163) TSVB should use "histogram:maxBars" and "histogram:barTarget" settings for auto instead of a default 100 buckets (elastic#83628) [Workplace Search] Initial rendering of Org Sources (elastic#84164) update geckodriver to 0.28 (elastic#84085) Fix timelion vis escapes single quotes (elastic#84196) [Security Solution] Fix incorrect time for dns histogram (elastic#83532) [DX] Bump TS version to v4.1 (elastic#83397) [Security Solution] Add endpoint policy revision number (elastic#83982) [Fleet] Integration Policies List view (elastic#83634) ...
flash1293
added a commit
that referenced
this pull request
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77161
Fixes #65630
This PR adds a new option
renderModeto expression loader and renderer params which is passed from the embedding (e.g. Lens embeddable class) to the expression renderer. There it can be used to change the rendering of the chart.This PR puts the new option into use as well by extending the Lens embeddable input in the same way and using the
noInteractivitymode for Lens visualizations embedded in Canvas (because filters don't work there anyway).The only user facing change is no brush functionality and no pointer cursor on click on Lens charts embedded in Canvas