Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kibana cli] expected help on 'kibana help' or 'kibana-plugin help' #6577

Closed
BigFunger opened this issue Mar 18, 2016 · 2 comments
Closed

[kibana cli] expected help on 'kibana help' or 'kibana-plugin help' #6577

BigFunger opened this issue Mar 18, 2016 · 2 comments
Labels
enhancement New value added to drive a business result Team:Operations Team label for Operations Team

Comments

@BigFunger
Copy link
Contributor

@epixa mentioned in #6402

Rather than error if the user doesn't specify a command in help, I think we should render the default text. Basically, I'd expect both of these to be valid ways to retrieve help text about the cli:

b0d9f88a-e9e4-11e5-9f67-26f389c02a4f.png

This will involve hacking the Command module used within the cli
@BigFunger BigFunger mentioned this issue Mar 18, 2016
Merged
@jbudz jbudz added the Team:Operations Team label for Operations Team label Nov 1, 2016
@tsullivan
Copy link
Member

I think this would be a good idea. Elasticsearch does work as expected:

[root@2f7b841c3a2d elasticsearch]# ./bin/elasticsearch-plugin help
        A tool for managing installed elasticsearch plugins

Commands
--------
list - Lists installed elasticsearch plugins
install - Install a plugin
remove - removes a plugin from Elasticsearch

Non-option arguments:
command

Option         Description
------         -----------
-h, --help     show help
-s, --silent   show minimal output
-v, --verbose  show verbose output
ERROR: Unknown command [help]

This gap is still valid as of 6.7.0

@epixa epixa added enhancement New value added to drive a business result and removed release_note:enhancement labels Mar 29, 2019
@tylersmalley
Copy link
Contributor

Closing this - --help is the defacto standard.

cee-chen added a commit that referenced this issue Feb 9, 2023
@cee-chen @kibanamachine
Upgrade EUI to v74.0.2 (#150634)
e5a0a5d 
## Summary

`eui@74.0.1` ⏩ `eui@74.0.2`

___

## [`74.0.2`](https://github.com/elastic/eui/tree/v74.0.2)

**Bug fixes**

- Fixed `EuiCard` to ensure `onClick` method only runs once when `title`
contains a React node
([#6551](elastic/eui#6551))
- Fixed `EuiSelectable` options with incorrect `aria-posinset` indices
when rendered with group labels not at the start of the array
([#6571](elastic/eui#6571))
- Fixed a bug with `EuiSearchBar` where filters with `multiSelect:
false` were not able to select a new option when an option was already
selected ([#6577](elastic/eui#6577))

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
1Copenut added a commit that referenced this issue Feb 14, 2023
@1Copenut @kibanamachine
Upgrade EUI to v75.0.0 (#150787)
584b2ff 
## Summary

`eui@74.0.2` ⏩ `eui@75.0.0`

___

## [`75.0.0`](https://github.com/elastic/eui/tree/v75.0.0)

- `EuiFlyout`s now automatically shard all fixed `EuiHeader`s on the
page. This means that interactions (mouse & keyboard) with items inside
`EuiHeader`s when flyouts are open will no longer trigger focus fighting
([#6566](elastic/eui#6566))
- `EuiFlyout`s now read out detailed screen reader dialog instructions
and hints on open ([#6566](elastic/eui#6566))

**Bug fixes**

- Fixed `EuiSelectable` options with incorrect `aria-posinset` indices
when rendered with group labels not at the start of the array
([#6571](elastic/eui#6571))
- Fixed a bug with `EuiSearchBar` where filters with `multiSelect:
false` were not able to select a new option when an option was already
selected ([#6577](elastic/eui#6577))

**Breaking changes**

- Removed the ability to customize the `role` prop of `EuiFlyout`s.
`EuiFlyout`s should always be dialog roles for screen reader
consistency. ([#6566](elastic/eui#6566))
- Removed `closeButtonAriaLabel` prop from `EuiFlyout` - use
`closeButtonProps['aria-label']` instead
([#6566](elastic/eui#6566))

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
justinkambic pushed a commit to justinkambic/kibana that referenced this issue Feb 23, 2023
@1Copenut @kibanamachine @justinkambic
Upgrade EUI to v75.0.0 (elastic#150787)
73fdcd8 
## Summary

`eui@74.0.2` ⏩ `eui@75.0.0`

___

## [`75.0.0`](https://github.com/elastic/eui/tree/v75.0.0)

- `EuiFlyout`s now automatically shard all fixed `EuiHeader`s on the
page. This means that interactions (mouse & keyboard) with items inside
`EuiHeader`s when flyouts are open will no longer trigger focus fighting
([elastic#6566](elastic/eui#6566))
- `EuiFlyout`s now read out detailed screen reader dialog instructions
and hints on open ([elastic#6566](elastic/eui#6566))

**Bug fixes**

- Fixed `EuiSelectable` options with incorrect `aria-posinset` indices
when rendered with group labels not at the start of the array
([elastic#6571](elastic/eui#6571))
- Fixed a bug with `EuiSearchBar` where filters with `multiSelect:
false` were not able to select a new option when an option was already
selected ([elastic#6577](elastic/eui#6577))

**Breaking changes**

- Removed the ability to customize the `role` prop of `EuiFlyout`s.
`EuiFlyout`s should always be dialog roles for screen reader
consistency. ([elastic#6566](elastic/eui#6566))
- Removed `closeButtonAriaLabel` prop from `EuiFlyout` - use
`closeButtonProps['aria-label']` instead
([elastic#6566](elastic/eui#6566))

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Team:Operations Team label for Operations Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tylersmalley @epixa @tsullivan @jbudz @BigFunger