Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service version deployment annotation placement looks off #66981

Closed
formgeist opened this issue May 19, 2020 · 1 comment · Fixed by #68829
Closed

[APM] Service version deployment annotation placement looks off #66981

formgeist opened this issue May 19, 2020 · 1 comment · Fixed by #68829
Assignees
@smith
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.9.0

Comments

@formgeist
Copy link
Contributor

formgeist commented May 19, 2020 •
edited by sorenlouv
Loading

Kibana version:

7.8.0-SNAPSHOT

Describe the bug:

The placement of the service.version annotation on the Time spent... chart is way off.

Screenshot 2020-05-19 at 10 44 01

Steps to reproduce:

  1. Go to to the Transactions page for RUM (which doesn't support Time spent...)

Solution
Don't show annotations on empty charts (charts without data)
@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.8.0 labels May 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith smith self-assigned this Jun 10, 2020
smith added a commit to smith/kibana that referenced this issue Jun 10, 2020
@smith
[APM] Don't show annotations on charts with no data
c5607a6 
Hide the annotations plot and legend when a chart has annotations but doesn't have any values in the series.

Fixes elastic#66981.
@smith smith mentioned this issue Jun 10, 2020
Merged
smith added a commit that referenced this issue Jun 11, 2020
@smith
[APM] Don't show annotations on charts with no data (#68829)
8aa1b39 
Hide the annotations plot and legend when a chart has annotations but doesn't have any values in the series.

Fixes #66981.
smith added a commit to smith/kibana that referenced this issue Jun 11, 2020
@smith
[APM] Don't show annotations on charts with no data (elastic#68829)
f95da05 
Hide the annotations plot and legend when a chart has annotations but doesn't have any values in the series.

Fixes elastic#66981.
smith added a commit that referenced this issue Jun 11, 2020
@smith
[APM] Don't show annotations on charts with no data (#68829) (#68841)
b66e462 
Hide the annotations plot and legend when a chart has annotations but doesn't have any values in the series.

Fixes #66981.
smith added a commit to smith/kibana that referenced this issue Jun 11, 2020
@smith
[APM] Don't show annotations on charts with no data (elastic#68829)
cc7a268 
Hide the annotations plot and legend when a chart has annotations but doesn't have any values in the series.

Fixes elastic#66981.
smith added a commit that referenced this issue Jun 11, 2020
@smith
[APM] Don't show annotations on charts with no data (#68829) (#68925)
ad96bc2 
Hide the annotations plot and legend when a chart has annotations but doesn't have any values in the series.

Fixes #66981.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Don't show annotations on charts with no data smith/kibana
4 participants
@smith @sorenlouv @formgeist @elasticmachine