Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Improve unenroll agent UX #67704

Closed
hbharding opened this issue May 28, 2020 · 10 comments
Closed

[Ingest Manager] Improve unenroll agent UX #67704

hbharding opened this issue May 28, 2020 · 10 comments
Assignees
Labels
design Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@hbharding
Copy link
Contributor

hbharding commented May 28, 2020

Related: elastic/beats#18825

Problem

Currently when asked to unenroll an agent, we don't provide any useful information about what this action means.

image

Things to figure out:

  • what happens after you unenroll an agent? Does the agent still appear in Fleet or does it go away? Can you re-enroll? Do you get redirected? etc.

Design

Figma file
Prototype

I added some additional information to the unenroll modal. Showing the agent ID in the title did not render well. Instead, I'm using a table to show both the Agent ID and Host Name for additional context. The same host could contain multiple agents, so showing the Agent ID is necessary, but the Host Name seems more meaningful.

Kapture 2020-07-09 at 13 56 18
image
image

@hbharding hbharding added design Team:Fleet Team label for Observability Data Collection Fleet team labels May 28, 2020
@hbharding hbharding self-assigned this May 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@EricDavisX
Copy link
Contributor

I'm posting this here and in elastic/beats#18825 -

  • one concern I have that I don't see commentary on, is making sure we have and provide in the API call the time that the agent was unenrolled (from the UI).

from api/ingest_manager/fleet/agents?page=1&perPage=20&showInactive=true

  • you can see the enrolled_at timestamp field, we should capture and add to the metadata an unenrolled_at timestamp. that field can be empty if we want / ned to populate it in the first place, and when empty it need not have any impact on the UI.

@EricDavisX
Copy link
Contributor

Same concern for when we revoke an enrollment API key - I don't think that was tracked either, it may be an even bigger concern for that API + use case.

@hbharding
Copy link
Contributor Author

related: #67409

@hbharding
Copy link
Contributor Author

hbharding commented Jul 9, 2020

Update

(cc @ph @nchaulet @mostlyjason @michalpristas )

I updated the issue description with my design. Is the information I provided in the unenroll modal sufficient and correct? The modal says:

Unenroll agent

{host + agent id for context}

Unenroll this agent to remove it from Fleet and prevent it from sending new data. Any data that was already sent by this agent will not be effected.

Are you sure you wish to continue?

If there is consensus with what i'm proposing, then this should be ready to be worked on on in elastic/beats#18825

@hbharding
Copy link
Contributor Author

Also, I was thinking it may make sense to redirect the user to the fleet page if they unenroll an agent while on the agent detail page. Currently, users remain on the agent detail page, and the status shows "unenrolling". Remaining on the page allows the user to access other actions on this page, like "assign new agent config"; however, I imagine choosing that action would lead to an error since the agent is in the process of being unenrolled. Thus, it might be simpler if we just redirected back to the Fleet page. Are there use cases I'm not thinking of for allowing the user to stay on the agent detail page?

@nchaulet
Copy link
Member

nchaulet commented Jul 9, 2020

what happens after you unenroll an agent? Does the agent still appear in Fleet or does it go away? Can you re-enroll? Do you get redirected? etc.

When you unenroll an agent the agent status will go to unenrolling untill the agent acknowledge the unenrollment the agent is going to be inactive and you will not see it in the list anymore (unless you toggle show inactive)

You can re-enroll an agent but it's going to be a new agent in fleet

@mostlyjason
Copy link
Contributor

@hbharding FYI we might need a new version for bulk unenroll in 7.10

@mostlyjason
Copy link
Contributor

@hbharding reopening since it seems there is now a force unenroll modal. it'd be good to incorporate that as well #72386

@mostlyjason mostlyjason reopened this Jul 21, 2020
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Jul 21, 2020
@mostlyjason
Copy link
Contributor

Closing, I'll create a new issue instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

6 participants