Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expressions] Create expression function to getSavedObjects #68328

Closed
3 tasks
lukeelmers opened this issue Jun 4, 2020 · 2 comments
Closed
3 tasks

[expressions] Create expression function to getSavedObjects #68328

lukeelmers opened this issue Jun 4, 2020 · 2 comments
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@lukeelmers
Copy link
Member

Part of #61769
Blocks #65988

  • create getSavedObject expression function (which should be the only one retrieving saved searches)
    • usage getSavedObject type="foo" id="abc123"
  • function returns a savedObject expression type
  • deprecate getSavedObject in the expression execution context (handler)
    • should be straightforward as this appears to only be used in kibana_context
@lukeelmers lukeelmers added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers added this to 7.9 in kibana-app-arch Jun 4, 2020
This was referenced Jun 4, 2020
Closed
Closed
@lukeelmers lukeelmers self-assigned this Jun 8, 2020
@lukeelmers lukeelmers moved this from 7.9 to 7.10 in kibana-app-arch Jun 8, 2020
@lukeelmers lukeelmers moved this from 7.10 - Tentative to 7.11 - Tentative in kibana-app-arch Jul 22, 2020
@lukeelmers lukeelmers removed this from 7.11 in kibana-app-arch Dec 14, 2020
@lukeelmers lukeelmers removed their assignment Dec 14, 2020
@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Apr 20, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Apr 28, 2021
@petrklapka petrklapka added 1 and removed 1 labels May 10, 2021
@ppisljar
Copy link
Member

closing this issue as it doesn't follow good practices. rather that exposing a single getSavedObject function we should have specific functions that retrieve specific types of saved objects.

for specific case mentioned above we are gonna provide getSavedSearch function #67901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukeelmers @ppisljar @elasticmachine @petrklapka