Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot define Custom Label for Sibling pipeline aggregations metrics on all visualizations #69376

Closed
lucabelluccini opened this issue Jun 17, 2020 · 6 comments · Fixed by #69688
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:MetricVis Metric visualization feature regression Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@lucabelluccini
Copy link
Contributor

lucabelluccini commented Jun 17, 2020

Kibana version: 7.7.0+

Elasticsearch version: 7.7.0+

Describe the bug:

It is no more possible to edit the Custom Label for any visualization with Metric type Sibling pipeline aggregations (E.g. Sum Bucket).

Steps to reproduce:

  1. Deploy the demo data Kibana Web Logs
  2. Create a Metric visualization
  3. Choose Sum Bucket as Metric type
  4. There is no Custom Label option

This seems not limited to Metric visualization, but all visualizations offering Sibling pipeline aggregations.

Expected behavior:

Presence of the Custom Label

Screenshots (if relevant):

image

Errors in browser console (if relevant):

None

Any additional context:

This seems to be a regression as it was present on 7.6.2

image

Also note the Custom Labels were not fully respected in 7.6.2

image

A workaround for my particular case might be to use Metric & Split, but I noticed the Custom Labels are not fully respected (only ABC shows up):

image

Maybe a regression due to the introduction/rewrite with Lens?

@lucabelluccini lucabelluccini added the bug Fixes for quality problems that affect the customer experience label Jun 17, 2020
@timroes timroes added regression Team:Visualizations Visualization editors, elastic-charts and infrastructure :KibanaApp/fix-it-week Feature:MetricVis Metric visualization feature labels Jun 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@markov00
Copy link
Member

This is somehow related to another regression: #69014

@DennisDyallo
Copy link

Hi guys! It's still not fixed unfortunately. This is a sibling aggregation on Bucket Avg. Custom label is missing

image

@markov00
Copy link
Member

markov00 commented Jul 6, 2020

@sulemanof could you please check this?
@DennisDyallo does that screenshot comes from the master branch?

@sulemanof
Copy link
Contributor

Hi @DennisDyallo !
In which branch have you checked this behavior?
It has been fixed for Kibana 7.9+/8.0 versions:

image

@DennisDyallo
Copy link

Oh, my sincerest apologies. I'm on 7.8. I'll sit tight and wait for 7.9 then! In the meantime, I can edit the JSON in the Stack Management -> Saved Object-view.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:MetricVis Metric visualization feature regression Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants