Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive karma tests #71002

Closed
53 of 54 tasks
joshdover opened this issue Jul 7, 2020 · 11 comments
Closed
53 of 54 tasks

Inactive karma tests #71002

joshdover opened this issue Jul 7, 2020 · 11 comments
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

joshdover commented Jul 7, 2020

When plugins were migrated to the Kibana Platform, any existing tests that were run using Karma stopped being picked up by the Karma test bundling system. We are making progress on removing this system entirely, but want to inform teams that these tests are not currently being executed. These tests should either be removed or refactored to use the Jest test runner. This is not blocking any work on the Platform team at this time, but there is a risk that the reduction in test coverage may cause future problems.

Command used to find these files:

git ls-files - {src,x-pack}/plugins/*/public/{**,*,}/__tests__/** | grep -Ev ".*\.test\.(js|ts|tsx)(\.snap)?\$" | grep -E "\.(js|ts|tsx)\$"

@elastic/kibana-app-arch

  • src/plugins/kibana_utils/public/storage/__tests__/storage.js
  • src/plugins/visualizations/public/legacy/__tests__/vis_update_objs/gauge_objs.js

@elastic/kibana-gis

  • src/plugins/maps_legacy/public/__tests__/map/kibana_map.js
  • src/plugins/maps_legacy/public/__tests__/map/service_settings.js (migrated Migrate service settings test to jest #70992)
  • src/plugins/region_map/public/__tests__/region_map_visualization.js
  • src/plugins/tile_map/public/__tests__/coordinate_maps_visualization.js
  • src/plugins/tile_map/public/__tests__/geohash_layer.js
  • x-pack/plugins/maps/public/classes/layers/__tests__/mock_sync_context.ts (util file)
  • x-pack/plugins/maps/public/classes/styles/vector/properties/__tests__/test_util.ts (util file)

@elastic/apm-ui

  • x-pack/plugins/apm/public/selectors/__tests__/mockData/anomalyData.ts

@elastic/kibana-canvas #73121

  • x-pack/plugins/canvas/public/__tests__/setup.js
  • x-pack/plugins/canvas/public/components/loading/__tests__/loading.js
  • x-pack/plugins/canvas/public/functions/__tests__/asset.js
  • x-pack/plugins/canvas/public/lib/__tests__/find_expression_type.js
  • x-pack/plugins/canvas/public/lib/__tests__/history_provider.js
  • x-pack/plugins/canvas/public/lib/__tests__/modify_path.js
  • x-pack/plugins/canvas/public/lib/__tests__/resolved_arg.js
  • x-pack/plugins/canvas/public/state/actions/__tests__/elements.get_sibling_context.js
  • x-pack/plugins/canvas/public/state/reducers/__tests__/elements.js
  • x-pack/plugins/canvas/public/state/reducers/__tests__/fixtures/action_creator.js
  • x-pack/plugins/canvas/public/state/reducers/__tests__/resolved_args.js
  • x-pack/plugins/canvas/public/state/selectors/__tests__/resolved_args.js
  • x-pack/plugins/canvas/public/state/selectors/__tests__/workpad.js

@elastic/stack-monitoring

  • x-pack/plugins/monitoring/public/components/alerts/__tests__/map_severity.js
  • x-pack/plugins/monitoring/public/components/chart/__tests__/get_color.js
  • x-pack/plugins/monitoring/public/components/chart/__tests__/get_last_value.js
  • x-pack/plugins/monitoring/public/components/chart/__tests__/get_title.js
  • x-pack/plugins/monitoring/public/components/chart/__tests__/get_values_for_legend.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/__tests__/config.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/__tests__/pipeline_state.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/boolean_edge.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/edge.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/edge_factory.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/if_vertex.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/index.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/plugin_vertex.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/queue_vertex.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/vertex.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/__tests__/vertex_factory.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/if_statement.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/make_statement.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/pipeline.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/plugin_statement.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/queue.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/statement.js
  • x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/pipeline/__tests__/utils.js
  • x-pack/plugins/monitoring/public/directives/main/__tests__/monitoring_main_controller.js
  • x-pack/plugins/monitoring/public/lib/__tests__/format_number.js
  • x-pack/plugins/monitoring/public/lib/logstash/__tests__/pipelines.js
  • x-pack/plugins/monitoring/public/services/__tests__/breadcrumbs.js
  • x-pack/plugins/monitoring/public/services/__tests__/executor.js
  • x-pack/plugins/monitoring/public/views/__tests__/base_controller.js
  • x-pack/plugins/monitoring/public/views/__tests__/base_table_controller.js

@elastic/observability-ui (couldn't find the Uptime team alias)

  • x-pack/plugins/uptime/public/components/monitor/status_details/location_map/embeddables/__tests__/__mocks__/mock.ts -- 90% sure this isn't related to Karma, but got picked up by the same glob pattern jest test
@joshdover joshdover added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jul 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

smith added a commit to smith/kibana that referenced this issue Jul 8, 2020
This file was referenced in elastic#71002 but is not being used. Delete it.
smith added a commit that referenced this issue Jul 8, 2020
This file was referenced in #71002 but is not being used. Delete it.
smith added a commit to smith/kibana that referenced this issue Jul 8, 2020
This file was referenced in elastic#71002 but is not being used. Delete it.
smith added a commit that referenced this issue Jul 8, 2020
This file was referenced in #71002 but is not being used. Delete it.
@spalger spalger mentioned this issue Jul 23, 2020
@jinmu03
Copy link
Contributor

jinmu03 commented Aug 5, 2020

@jasonrhodes @thomasneirynck @lukeelmers Karma has been removed( #73126), please migrate the tests listed in this issue to Jest or remove them.

@lukeelmers
Copy link
Member

@jinmu03 PR for migrating the remaining app arch tests is up here.

@thomasneirynck
Copy link
Contributor

This is the PR for the legacy maps code: #74668

@joshdover
Copy link
Contributor Author

Ping @chrisronline as well for the Stack Monitoring tests

@chrisronline
Copy link
Contributor

@joshdover What's the timeline for this?

@dgieselaar
Copy link
Member

@joshdover the APM test was removed by Nathan in 67be99d. I'll update the description.

@chrisronline
Copy link
Contributor

@joshdover PR up for stack monitoring tests: #75301

@mshustov
Copy link
Contributor

x-pack/plugins/uptime/public/components/monitor/status_details/location_map/embeddables/tests/mocks/mock.ts -- 90% sure this isn't related to Karma, but got picked up by the same glob pattern

It's handled by jest, so it's not a blocker. @shahzad31 could you confirm, please?

Another file that still matches the pattern is
https://github.com/elastic/kibana/blob/e43efca3097859d72be2e8a745287f7d7eb335a0/x-pack/plugins/canvas/public/__tests__/setup.js
@spalger Has it been missed in #73121 or we still need it?

@shahzad31
Copy link
Contributor

@restrry you are right the test is handled by jest

x-pack/plugins/uptime/public/components/monitor/status_details/location_map/embeddables/tests/mocks/mock.ts

@thomasneirynck thomasneirynck moved this from To do to Done (past versions) in Maps Aug 27, 2020
@thomasneirynck thomasneirynck moved this from Done (past versions) to Done (current version) in Maps Aug 27, 2020
@spalger
Copy link
Contributor

spalger commented Aug 31, 2020

@restrry the canvas file was mentioning enzyme, which isn't used in the browser tests best I know so I assumed it was used by jest tests somehow. I'm guessing that the file isn't used by anything so I submitted #76295

@mshustov mshustov added this to Done (7.10) in kibana-core [DEPRECATED] Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
Maps
  
Done (current version)
Development

No branches or pull requests

10 participants