Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable angular debug data in production build #7125

Closed
pemontto opened this issue May 4, 2016 · 3 comments · Fixed by #7929
Closed

Disable angular debug data in production build #7125

pemontto opened this issue May 4, 2016 · 3 comments · Fixed by #7929
Assignees
@ppisljar
Labels
good first issue low hanging fruit release_note:enhancement

Comments

@pemontto
Copy link

pemontto commented May 4, 2016

I recently saw this article and thought it would be interesting to see if it had much of an impact on Kibana as I can see plenty of ng-scop and ng-binding classes in the HTML.

Angular docs - debugInfoEnabled
@rashidkpc
Copy link
Contributor

https://docs.angularjs.org/guide/production#disabling-debug-data

@rashidkpc rashidkpc changed the title Investigate potential Angular performance improvment Disable angular debug data in production build May 5, 2016
@ppisljar
Copy link
Member

ppisljar commented Jul 4, 2016

I think this is definetely a good idea, but as this is for production only we should probably only add it to the final packages ?

@epixa
Copy link
Contributor

epixa commented Jul 8, 2016

@ppisljar Rather than relying on the type of build, we can probably rely on the "dev" status that is set via bin/kibana --dev.

@ppisljar ppisljar mentioned this issue Jul 9, 2016
Closed
ppisljar added a commit to ppisljar/kibana that referenced this issue Jul 10, 2016
@ppisljar
fix elastic#7125 - disable angular debug info
ea8ba9f
@ppisljar ppisljar self-assigned this Jul 11, 2016
@ppisljar ppisljar added ready and removed ready labels Jul 17, 2016
@ppisljar ppisljar mentioned this issue Aug 4, 2016
Merged
ppisljar added a commit to ppisljar/kibana that referenced this issue Aug 11, 2016
@ppisljar
fix elastic#7125 - disable angular debug info
123776f
ppisljar added a commit to ppisljar/kibana that referenced this issue Aug 11, 2016
@ppisljar
fix elastic#7125 - disable angular debug info
440a4ca
ppisljar added a commit to ppisljar/kibana that referenced this issue Oct 3, 2016
@ppisljar
fix elastic#7125 - disable angular debug info
ffe6949
ppisljar added a commit to ppisljar/kibana that referenced this issue Oct 3, 2016
@ppisljar
fix elastic#7125 - disable angular debug info
4bd0521
ppisljar added a commit to ppisljar/kibana that referenced this issue Oct 29, 2016
@ppisljar
fix elastic#7125 - disable angular debug info
b3957a9
ppisljar added a commit to ppisljar/kibana that referenced this issue Oct 29, 2016
@ppisljar
fix elastic#7125 - disable angular debug info
3972808
ppisljar added a commit that referenced this issue Oct 29, 2016
@ppisljar
Do not use angular debug mode unless in development (#7929)
4755a39 
* fix #7125 - disable angular debug info
elastic-jasper added a commit that referenced this issue Oct 29, 2016
@elastic-jasper
Do not use angular debug mode unless in development
59bb12a 
Backports PR #7929

**Commit 1:**
fix #7125 - disable angular debug info

* Original sha: b3957a9
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-04T08:25:47Z

**Commit 2:**
fix #7125 - disable angular debug info

* Original sha: 3972808
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-04T08:26:09Z

**Commit 3:**
updating to disable debug info when environment name is set to production

* Original sha: 268fdb5
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-04T10:02:00Z

**Commit 4:**
using --dev flag

* Original sha: d1c6ce4
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-11T16:26:12Z

**Commit 5:**
updating tests to not depend on angular.scope()

* Original sha: 4f83b21
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-10-03T09:39:29Z
@elastic-jasper elastic-jasper mentioned this issue Oct 29, 2016
Merged
ppisljar pushed a commit that referenced this issue Oct 29, 2016
@elastic-jasper @ppisljar
Do not use angular debug mode unless in development (#8891)
ad43652 
Backports PR #7929

**Commit 1:**
fix #7125 - disable angular debug info

* Original sha: b3957a9
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-04T08:25:47Z

**Commit 2:**
fix #7125 - disable angular debug info

* Original sha: 3972808
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-04T08:26:09Z

**Commit 3:**
updating to disable debug info when environment name is set to production

* Original sha: 268fdb5
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-04T10:02:00Z

**Commit 4:**
using --dev flag

* Original sha: d1c6ce4
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-11T16:26:12Z

**Commit 5:**
updating tests to not depend on angular.scope()

* Original sha: 4f83b21
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-10-03T09:39:29Z
nreese pushed a commit to nreese/kibana that referenced this issue Nov 10, 2016
@ppisljar @nreese
Do not use angular debug mode unless in development (elastic#7929)
b2142f3 
* fix elastic#7125 - disable angular debug info
airow pushed a commit to airow/kibana that referenced this issue Feb 16, 2017
@elastic-jasper @ppisljar
Do not use angular debug mode unless in development (elastic#8891)
0a514f0 
Backports PR elastic#7929

**Commit 1:**
fix elastic#7125 - disable angular debug info

* Original sha: b3957a9
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-04T08:25:47Z

**Commit 2:**
fix elastic#7125 - disable angular debug info

* Original sha: 3972808
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-04T08:26:09Z

**Commit 3:**
updating to disable debug info when environment name is set to production

* Original sha: 268fdb5
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-04T10:02:00Z

**Commit 4:**
using --dev flag

* Original sha: d1c6ce4
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-11T16:26:12Z

**Commit 5:**
updating tests to not depend on angular.scope()

* Original sha: 4f83b21
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-10-03T09:39:29Z

Former-commit-id: ad43652
jbudz added a commit that referenced this issue Sep 18, 2023
@breehall @kibanamachine
@cee-chen @jbudz
Upgrade EUI to v88.3.0 (#166292)
b7ba000 
EUI `88.2.0` ➡️ `88.3.0`

## [`88.3.0`](https://github.com/elastic/eui/tree/v88.3.0)

- `EuiGlobalToastList` now shows a "Clear all" button by default once
above a certain number of toasts (defaults to 3). This threshold is
configurable with the `showClearAllButtonAt` prop
([#7111](elastic/eui#7111))
- Added an optional `onClearAllToasts` callback to `EuiGlobalToastList`
([#7111](elastic/eui#7111))
- Added the `value`, `onChange`, and `onCancel` props that allow
`EuiInlineEdit` to be used as a controlled component
([#7157](elastic/eui#7157))
- Added `grabOmnidirectional`, `transitionLeftIn`, `transitionLeftOut`,
`transitionTopIn`, and `transitionTopOut` icon glyphs.
([#7168](elastic/eui#7168))

**Bug fixes**

- Fixed `EuiInlineEdit` components to correctly spread `...rest`
attributes to the parent wrapper
([#7157](elastic/eui#7157))
- Fixed `EuiListGroupItem` to correctly render the `extraAction` button
when `showToolTip` is also passed
([#7159](elastic/eui#7159))

**Dependency updates**

- Updated `@hello-pangea/dnd` to v16.3.0
([#7125](elastic/eui#7125))
- Updated `@types/lodash` to v4.14.198
([#7126](elastic/eui#7126))

**Accessibility**

- `EuiAccordion` now correctly respects reduced motion settings
([#7161](elastic/eui#7161))
- `EuiAccordion` now shows a focus outline to keyboard users around its
revealed children on open
([#7161](elastic/eui#7161))

**CSS-in-JS conversions**

- Converted `EuiSplitPanel` to Emotion
([#7172](elastic/eui#7172))


⚠️ As a quick heads up, serverless tests appear to have been extremely
flake/failure-prone the last couple weeks, particularly Cypress tests.
We've evaluated the listed failures and fixed ones that were related to
changes in this PR, and we're relatively confident the remaining
failures are not related to changes from EUI. Please let us know if you
think this is not the case.

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Cee Chen <constance.chen@elastic.co>
Co-authored-by: Jon <jon@elastic.co>
jbudz added a commit that referenced this issue Sep 20, 2023
@cee-chen @breehall
@kibanamachine @jbudz
Upgrade EUI to v88.3.0 (#166676)
102dbe2 
⚠️ NOTE: This PR is a copy of #166292 (which was reverted due to failing
Storybook builds). This is the same exact PR but with Storybook building
fixed.

---

EUI `88.2.0` ➡️ `88.3.0`

## [`88.3.0`](https://github.com/elastic/eui/tree/v88.3.0)

- `EuiGlobalToastList` now shows a "Clear all" button by default once
above a certain number of toasts (defaults to 3). This threshold is
configurable with the `showClearAllButtonAt` prop
([#7111](elastic/eui#7111))
- Added an optional `onClearAllToasts` callback to `EuiGlobalToastList`
([#7111](elastic/eui#7111))
- Added the `value`, `onChange`, and `onCancel` props that allow
`EuiInlineEdit` to be used as a controlled component
([#7157](elastic/eui#7157))
- Added `grabOmnidirectional`, `transitionLeftIn`, `transitionLeftOut`,
`transitionTopIn`, and `transitionTopOut` icon glyphs.
([#7168](elastic/eui#7168))

**Bug fixes**

- Fixed `EuiInlineEdit` components to correctly spread `...rest`
attributes to the parent wrapper
([#7157](elastic/eui#7157))
- Fixed `EuiListGroupItem` to correctly render the `extraAction` button
when `showToolTip` is also passed
([#7159](elastic/eui#7159))

**Dependency updates**

- Updated `@hello-pangea/dnd` to v16.3.0
([#7125](elastic/eui#7125))
- Updated `@types/lodash` to v4.14.198
([#7126](elastic/eui#7126))

**Accessibility**

- `EuiAccordion` now correctly respects reduced motion settings
([#7161](elastic/eui#7161))
- `EuiAccordion` now shows a focus outline to keyboard users around its
revealed children on open
([#7161](elastic/eui#7161))

**CSS-in-JS conversions**

- Converted `EuiSplitPanel` to Emotion
([#7172](elastic/eui#7172))

---------

Co-authored-by: Bree Hall <briannajdhall@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jon <jon@elastic.co>
delanni pushed a commit to delanni/kibana that referenced this issue Sep 21, 2023
@cee-chen @breehall
@kibanamachine @jbudz @delanni
Upgrade EUI to v88.3.0 (elastic#166676)
735659d 
⚠️ NOTE: This PR is a copy of elastic#166292 (which was reverted due to failing
Storybook builds). This is the same exact PR but with Storybook building
fixed.

---

EUI `88.2.0` ➡️ `88.3.0`

## [`88.3.0`](https://github.com/elastic/eui/tree/v88.3.0)

- `EuiGlobalToastList` now shows a "Clear all" button by default once
above a certain number of toasts (defaults to 3). This threshold is
configurable with the `showClearAllButtonAt` prop
([elastic#7111](elastic/eui#7111))
- Added an optional `onClearAllToasts` callback to `EuiGlobalToastList`
([elastic#7111](elastic/eui#7111))
- Added the `value`, `onChange`, and `onCancel` props that allow
`EuiInlineEdit` to be used as a controlled component
([elastic#7157](elastic/eui#7157))
- Added `grabOmnidirectional`, `transitionLeftIn`, `transitionLeftOut`,
`transitionTopIn`, and `transitionTopOut` icon glyphs.
([elastic#7168](elastic/eui#7168))

**Bug fixes**

- Fixed `EuiInlineEdit` components to correctly spread `...rest`
attributes to the parent wrapper
([elastic#7157](elastic/eui#7157))
- Fixed `EuiListGroupItem` to correctly render the `extraAction` button
when `showToolTip` is also passed
([elastic#7159](elastic/eui#7159))

**Dependency updates**

- Updated `@hello-pangea/dnd` to v16.3.0
([elastic#7125](elastic/eui#7125))
- Updated `@types/lodash` to v4.14.198
([elastic#7126](elastic/eui#7126))

**Accessibility**

- `EuiAccordion` now correctly respects reduced motion settings
([elastic#7161](elastic/eui#7161))
- `EuiAccordion` now shows a focus outline to keyboard users around its
revealed children on open
([elastic#7161](elastic/eui#7161))

**CSS-in-JS conversions**

- Converted `EuiSplitPanel` to Emotion
([elastic#7172](elastic/eui#7172))

---------

Co-authored-by: Bree Hall <briannajdhall@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jon <jon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppisljar ppisljar

Labels
good first issue low hanging fruit release_note:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not use angular debug mode unless in development ppisljar/kibana
4 participants
@epixa @pemontto @rashidkpc @ppisljar