Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align eslint rules for js & ts files #74385

Open
mshustov opened this issue Aug 5, 2020 · 3 comments
Open

Align eslint rules for js & ts files #74385

mshustov opened this issue Aug 5, 2020 · 3 comments
Labels
enhancement New value added to drive a business result Team:Operations Team label for Operations Team

Comments

@mshustov
Copy link
Contributor

mshustov commented Aug 5, 2020

Kibana codebase is migrating to typescript, but our linter setup is still out of sync for *.js & *.ts files. For example, we don't enforce a lot of import/* eslint-plugin rules for *.ts files.
https://github.com/elastic/kibana/blob/master/packages/eslint-config-kibana/javascript.js#L92-L100
We need to sync rules for both *.js & *.ts files and fix already leaked violations.

@mshustov mshustov added the enhancement New value added to drive a business result label Aug 5, 2020
@watson watson added the Team:Operations Team label for Operations Team label Jul 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@watson
Copy link
Member

watson commented Jul 24, 2023

It's been a while since this issue was raised, and we've come a long way in converting to TypeScript. Is this still a problem, or can we close this issue?

@mistic
Copy link
Member

mistic commented Sep 1, 2023

I think this issue is still applying to some options missing sync between both envs. Not high priority though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Operations Team label for Operations Team
Projects
No open projects
Development

No branches or pull requests

4 participants