Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Remember last-used configuration when switching between incompatible configurations #75204

Closed
2 tasks
wylieconlon opened this issue Aug 17, 2020 · 3 comments
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@wylieconlon
Copy link
Contributor

In general, users are expecting the Lens editor to have a "memory" when switching from one configuration to another, and then back. This is particular important when they are temporarily looking at something that is incompatible, such as:

  • Switching between incompatible functions, such as Date Histogram -> Terms -> Date Histogram. In this case the user would expect the field that they previously selected to still be selected
  • Switching between the XY chart and pie charts, the user is reset to the default visualization options each time. Users would expect any visualization-specific settings to be kept

cc @AlonaNadler if you can come up with other examples

Implementation note

I think these features should be implemented separately. I don't think they can or should be implemented as a general undo/redo system, because it's specific to certain flows.

  • When switching incompatible functions, the datasource could track "previous functions" for the specific dimension, and restore on switch. This state should not be saved in the Lens doc.
  • When switching between completely separate chart types, the editor frame would need to be involved to store a "previous state" and restore it by applying equality checks, for example equality of the column IDs and metadata. This should not be saved in the Lens doc.
@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 17, 2020
@wylieconlon wylieconlon added this to Long-term goals in Lens via automation Aug 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula
Copy link
Contributor

This seems related to the undo redo functionality

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Sep 6, 2023
@stratoula
Copy link
Contributor

Closing this as this will be solved when we have the undo redo functionality #54971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Long-term goals
Development

No branches or pull requests

4 participants