Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Dimension editor should allow fieldless operations #75231

Closed
wylieconlon opened this issue Aug 17, 2020 · 4 comments · Fixed by #78080
Closed

[Lens] Dimension editor should allow fieldless operations #75231

wylieconlon opened this issue Aug 17, 2020 · 4 comments · Fixed by #78080
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@wylieconlon
Copy link
Contributor

wylieconlon commented Aug 17, 2020

To support the filters aggregation and future calculations like math, we will need the editor to sometimes hide the field selector. When switching to and from the fieldless operation, Lens should remember the last-used field.

Introducing a fieldless operation should probably not affect any of the suggestion logic that we currently apply, such as auto-selecting a field for a function.

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 17, 2020
@wylieconlon wylieconlon added this to Long-term goals in Lens via automation Aug 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon moved this from Long-term goals to 7.10 in Lens Aug 17, 2020
@flash1293 flash1293 added the enhancement New value added to drive a business result label Aug 18, 2020
@flash1293
Copy link
Contributor

When we drop the requirement to remember the last used field, we could implement this with little effort by introducing a hidden virtual field none which hides the field select when selected by choosing a field less operation.

All other interactions would continue in the same way, but it wouldn't switch back to the last used field e.g. when going from "Top values of field1" to "Filters" back to "Top values" - in this case you would have to pick a field again.

@wylieconlon do you have another idea how we could represent this?
@AlonaNadler what do you think about the behavior in this case (switching to filters and back requires you to pick a field again)?

@wylieconlon
Copy link
Contributor Author

I was expecting that we would implement the various pieces of this in three phases that can be done in parallel:

@flash1293
Copy link
Contributor

Makes sense, it seems like we need the first two things for a nice experience to merge the filters PR, then adding the third point as an improvement later (probably after 7.10)

Lens automation moved this from 7.10 to Done Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants