Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control visualizations resetting when multi-select drop down reaches the bottom of the visualization #76142

Closed
jerodwaldman opened this issue Aug 27, 2020 · 3 comments · Fixed by #76573
Labels
bug Fixes for quality problems that affect the customer experience Feature:Input Control Input controls visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed

Comments

@jerodwaldman
Copy link

jerodwaldman commented Aug 27, 2020

Kibana version:
7.8.1

Elasticsearch version:
7.8.1

Server OS version:
Linux

Browser version:
Chrome / Firefox

Browser OS version:
Windows

Original install method (e.g. download page, yum, from source, etc.):
Docker install from source

Describe the bug:
We recently upgraded from 7.5.1 to 7.8.1 and there seems to be a change in behavior for control visualizations. When a multi-select drop down is used to select multiple items in the list, it will continue to fill the open space under the control of the visualization until the bottom of the visualization is reached. At this point, the control selector resets the control visualization back to the last applied state. In version 7.5.1, this was not the case. In 7.5.1, the visualization would continue to add selected items to the list and if it hit the bottom of the visualization white space, it would cause the visualization to start to scroll, which in this case, is perfectly acceptable.

Steps to reproduce:

  1. Have a multi-select drop down control visualization
  2. Adjust the padding at the bottom of the control visualization to have less room
  3. Select multiple items from the list until the white space fills up and it will eventually reset the control to no items selected

Expected behavior:
The expected behavior is what we have in our 7.5.1 cluster where rather than resetting the control when the list reaches the bottom of the visualization, it simply causes the visualization to scroll and allows for more items to be selected.

Screenshots (if relevant):
This is before clicking another option in the multi-select drop down. Right after I click any of these, it will force the drop down list to reach the bottom of the visualization, causing the entire control visualization to reset.
image

This is after clicking one more test from that drop down showing that it clears all previously selected content in the controls of that visualization.
image

This is the same visualization in our 7.5.1 production cluster where it causes the visualization to scroll when you select multiple entries from the list that extend out of the bounds of the visualization.
image

Errors in browser console (if relevant):
No console errors are displayed

Provide logs and/or server output (if relevant):
Not relevant

Any additional context:

@myasonik myasonik added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed labels Aug 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@adamquan
Copy link

adamquan commented Sep 1, 2020

Did someone get the chance to take a look at this and confirm?

@ThomThomson
Copy link
Contributor

I was able to re-create it in 7.8.1 - it seems that the selections are cleared any time the controls panel is re-sized. The act of adding a scroll bar to the side seems to count as a re-size.

This console error appears, but it seems like a symptom rather than a cause:

Screen Shot 2020-09-01 at 11 14 49 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Input Control Input controls visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants