Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix Data Grid header layout for EUI v29.3.0 #79066

Closed
walterra opened this issue Oct 1, 2020 · 2 comments
Closed

[ML] Fix Data Grid header layout for EUI v29.3.0 #79066

walterra opened this issue Oct 1, 2020 · 2 comments

Comments

@walterra
Copy link
Contributor

walterra commented Oct 1, 2020

EUI v29.3.0 introduces new actions for the data grid's header column. Once the PR to update Kibana to use v29.3.0 is in we need to follow up to adjust the layout of the ML/Transform plugin's custom header with chart histograms.

This how the actions popover toggle will look as is after the update to v29.3.0:

image

The vertical middle alignment of the popover toggle doesn't blend in well with the custom charts. A quick fix will be to just disable the new column actions which is doable via a column prop.

@walterra walterra self-assigned this Oct 1, 2020
@walterra walterra added :ml Feature:Data Frame Analytics ML data frame analytics features Feature:Transforms ML transforms v7.10.0 labels Oct 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson
Copy link
Contributor

Closing as fixed by #79459, which hides the column actions when the mini charts are visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants