Upgraded EUI to v29.3.0 #78870

chandlerprall · 2020-09-29T20:54:17Z

Summary

`29.3.0`

Added both option to flush prop of EuiButtonEmpty (#4084)

Bug fixes

Fixed EuiRange and EuiDualRange display of internal spacer (#4084)
Fixed EuiFieldSearch padding for the different states (#4084)
Fixed EuiCheckableCard disabled but checked styles (#4084)

Theme: Amsterdam

Fixed line-height on EuiTitle (#4079)

`29.2.0`

Improved contrast for EuiIcon and EuiButtonIcon named colors. This affects EuiHealth which uses the EuiIcon colors. (#4049)
Added color accent to EuiButtonIcon (#4049)

Theme: Amsterdam

Removed border-radius from EuiCallout (#4066)
Updated styles for EuiToast (#4076)

`29.1.0`

Added footer row to EuiDataGrid via the renderFooterCellValue prop (#3770)
Added column header menu to EuiDataGrid (#3087)
Added horizontal line separator to EuiContextMenu (#4018)
Added controlled pagination props to EuiInMemoryTablee (#4038)
Added gutterSize, popoverBreakpoints, popoverButtonProps, and popoverProps props to EuiHeaderLinks (#4046)
Added 'all' and 'none' options to the sizes prop of EuiHideFor and EuiShowFor (#4046)

Bug fixes

Fixed EuiTextColor playground error due to color prop not getting captured by the documentation generator (#4058)

chandlerprall · 2020-09-29T23:28:57Z

Putting back in draft while I make this actually an upgrade.

I don’t think this was intended to change when I ran the updater

cchaos · 2020-10-01T02:25:57Z

Test looks flakey. One last time for the night.
Jenkins, test this

Whelp, I tried. Jenkins ain't listening to me ☹️

spalger · 2020-10-01T04:11:42Z

We're getting pretty close to implementing limits for bundle size increases in #78205 starting with limits that prevent increasing any bundle more than 5kb above its current size. This upgrade increases the size of the shared-ui-deps bundle by 500kb. Is this an expected or understood increase? I don't see anything in the changelog that would justify a size increase like that.

chandlerprall · 2020-10-01T04:16:04Z

We're getting pretty close to implementing limits for bundle size increases in #78205 starting with limits that prevent increasing any bundle more than 5kb above its current size. This upgrade increases the size of the shared-ui-deps bundle by 500kb. Is this an expected or understood increase? I don't see anything in the changelog that would justify a size increase like that.

That is quite the jump. I'll take a look into what's causing it.

walterra · 2020-10-01T08:02:15Z

I checked the existing uses of data grid in the ML/Transform plugin. Everything works well, we'll just need to adjust the design of the custom headers with the histogram charts, I created an issue here to follow up once this PR in (#79066). Great update with the new actions for data grid columns!

lizozom

Lgtm

cchaos

Design LGTM! 😉

poffdeluxe

Canvas changes lgtm

spalger

Looks like the size increase is caused by some new proptypes being automatically generated from TypeScript types, which are pretty massive in the uncompressed code but the 500kb increase is reduced to about 3kb with brotoli compression and 15kb with gzip compression. I think that's still pretty high, and something that I highly doubt provides any benefit to Kibana as we already validate against the TypeScript types these are derived from.

spalger · 2020-10-01T20:54:41Z

Just pushed a commit that will strip the proptypes from eui when building the ui-shared-deps bundle for production. Since these prop-types are added in a build step there's little-to-no risk that the propTypes are actually required for EUI to function correctly. In my testing locally this actually causes a reduction in the @elastic specific portion of the ui-shared-deps bundles.

spalger

LGTM!

patrykkopycinski

SIEM/Endpoint changes LGTM!

kertal

Doesn't seem that any KibanaApp code was modified by this update, but I've quickly checked the KibanaApp owned apps, and they are still alive and flourishing. Looking forward to used the features of this update!

kibanamachine · 2020-10-05T18:38:54Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 29f248a
Flaky suites:
- xpack-securitySolutionCypress

Test Failures

Creates and activates a new EQL rule with a sequence.Detection rules, EQL Creates and activates a new EQL rule with a sequence

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/79522

TypeError: Cannot read property 'apply' of undefined
    at listener (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:173184:19)
    at arrayMap (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:25373:23)
    at Function.map (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:34314:14)
    at $Cypress.events.emitMap (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:173188:16)
    at $Cypress.parent.<computed> [as emitMap] (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:173131:33)
    at $Cypress.action (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:166487:31)
    at fail (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:169982:22)
    at http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:169811:14
    at tryCatcher (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:10325:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:8260:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:8317:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:8362:10)
    at Promise._settlePromises (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:8438:18)
    at _drainQueueStep (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:5032:12)
    at _drainQueue (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:5025:9)
    at Async.../../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:5041:5)

Metrics [docs]

@kbn/ui-shared-deps asset size

id	before	after	diff
`css`	643.8KB	645.2KB	+1.3KB
`kbn-ui-shared-deps.@elastic.js`	2.8MB	2.3MB	-520.2KB
`kbn-ui-shared-deps.js`	4.6MB	4.6MB	-11.0B
total			-518.9KB

async chunks size

id	before	after	diff
`canvas`	1.5MB	1.5MB	+8.0B
`discover`	438.4KB	438.4KB	+8.0B
`enterpriseSearch`	428.6KB	428.7KB	+28.0B
`lens`	1.0MB	1.0MB	+8.0B
`securitySolution`	10.3MB	10.3MB	+398.0B
total			+450.0B

distributable file count

id	before	after	diff
`default`	47107	47114	+7
`oss`	28597	28604	+7

page load bundle size

id	before	after	diff
`embeddable`	290.7KB	290.7KB	+8.0B
`navigation`	21.9KB	21.7KB	-174.0B
`visTypeTimeseries`	136.9KB	136.9KB	+8.0B
total			-158.0B

History

💚 Build #78940 succeeded b97024f
💚 Build #78583 succeeded 6489e4e
💔 Build #78573 failed 6489e4e
💔 Build #78569 failed a7a88e9
💚 Build #78521 succeeded d0e2358

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2020-10-07T18:44:39Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78870 or prevent reminders by adding the backport:skip label.

chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 29, 2020

chandlerprall requested a review from a team September 29, 2020 20:54

chandlerprall requested review from a team as code owners September 29, 2020 22:16

chandlerprall marked this pull request as draft September 29, 2020 23:29

chandlerprall and others added 6 commits September 30, 2020 15:01

Upgraded EUI to v29.2.0

ae685c8

Remove hacks on top of EuiHeaderLink(s)

aa1b40e

Actual update to eui@29.2.0

2e64d17

Resolve typescript issue when omitting a key over a union

f50c3f4

Resolve nav menu test's expectations

3a7be07

Fix lint issue

d0e2358

chandlerprall force-pushed the eui-29-2-0 branch from 32d3033 to d0e2358 Compare September 30, 2020 21:11

Update to 29.3.0

a7a88e9

cchaos changed the title ~~Upgraded EUI to v29.2.0~~ Upgraded EUI to v29.3.0 Oct 1, 2020

Revert vega snapshot update

6489e4e

I don’t think this was intended to change when I ran the updater

chandlerprall marked this pull request as ready for review October 1, 2020 04:07

chandlerprall requested review from a team as code owners October 1, 2020 04:07

walterra mentioned this pull request Oct 1, 2020

[ML] Fix Data Grid header layout for EUI v29.3.0 #79066

Closed

lizozom approved these changes Oct 1, 2020

View reviewed changes

cchaos approved these changes Oct 1, 2020

View reviewed changes

poffdeluxe approved these changes Oct 1, 2020

View reviewed changes

spalger reviewed Oct 1, 2020

View reviewed changes

spalger added 2 commits October 1, 2020 13:31

Merge branch 'master' of github.com:elastic/kibana into pr/78870

c15ac90

[ui-shared-deps] strip proptypes from ui-shared-deps production build

b97024f

spalger approved these changes Oct 1, 2020

View reviewed changes

patrykkopycinski approved these changes Oct 2, 2020

View reviewed changes

walterra mentioned this pull request Oct 5, 2020

[ML] Hide Data Grid column options when histogram charts are enabled. #79459

Merged

2 tasks

kertal approved these changes Oct 5, 2020

View reviewed changes

Merge branch 'master' into eui-29-2-0

29f248a

chandlerprall merged commit 3bad1fc into elastic:master Oct 5, 2020

chandlerprall deleted the eui-29-2-0 branch October 5, 2020 18:44

chandlerprall mentioned this pull request Oct 5, 2020

[7.x] Upgraded EUI to v29.3.0 #79552

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 7, 2020

chandlerprall added the backport:skip This commit does not require backporting label Oct 7, 2020

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgraded EUI to v29.3.0 #78870

Upgraded EUI to v29.3.0 #78870

chandlerprall commented Sep 29, 2020 •

edited by cchaos

Loading

chandlerprall commented Sep 29, 2020

cchaos commented Oct 1, 2020 •

edited

Loading

spalger commented Oct 1, 2020 •

edited

Loading

chandlerprall commented Oct 1, 2020

walterra commented Oct 1, 2020

lizozom left a comment

cchaos left a comment

poffdeluxe left a comment

spalger left a comment

spalger commented Oct 1, 2020

spalger left a comment

patrykkopycinski left a comment

kertal left a comment

kibanamachine commented Oct 5, 2020

Stack Trace

kibanamachine commented Oct 7, 2020

Upgraded EUI to v29.3.0 #78870

Upgraded EUI to v29.3.0 #78870

Conversation

chandlerprall commented Sep 29, 2020 • edited by cchaos Loading

Summary

29.3.0

29.2.0

29.1.0

chandlerprall commented Sep 29, 2020

cchaos commented Oct 1, 2020 • edited Loading

spalger commented Oct 1, 2020 • edited Loading

chandlerprall commented Oct 1, 2020

walterra commented Oct 1, 2020

lizozom left a comment

Choose a reason for hiding this comment

cchaos left a comment

Choose a reason for hiding this comment

poffdeluxe left a comment

Choose a reason for hiding this comment

spalger left a comment

Choose a reason for hiding this comment

spalger commented Oct 1, 2020

spalger left a comment

Choose a reason for hiding this comment

patrykkopycinski left a comment

Choose a reason for hiding this comment

kertal left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 5, 2020

💛 Build succeeded, but was flaky

Test Failures

Stack Trace

Metrics [docs]

@kbn/ui-shared-deps asset size

async chunks size

distributable file count

page load bundle size

History

kibanamachine commented Oct 7, 2020

chandlerprall commented Sep 29, 2020 •

edited by cchaos

Loading

`29.3.0`

`29.2.0`

`29.1.0`

cchaos commented Oct 1, 2020 •

edited

Loading

spalger commented Oct 1, 2020 •

edited

Loading