Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] (Accessibility) Focus is lost when deleting a layer #83595

Closed
myasonik opened this issue Nov 17, 2020 · 2 comments · Fixed by #84900
Closed

[Lens] (Accessibility) Focus is lost when deleting a layer #83595

myasonik opened this issue Nov 17, 2020 · 2 comments · Fixed by #84900
Assignees
@mbondyra
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens loe:small Small Level of Effort Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG A
Projects
Lens a11y

Comments

@myasonik
Copy link
Contributor

myasonik commented Nov 17, 2020 •
edited
Loading

The issue

When using the keyboard to reset or delete a layer, focus moves to the <body> and relies on the browser to guess where to put focus next. Browsers have gotten pretty good at this but it can cause issues with some assistive tech still and can be confusing to users.

The fix

  • After resetting a layer, move focus to the first tabbable item item of the layer panel.
  • When deleting a layer, move focus somewhere sensible... (Maybe the whole sidebar? Particularly good choice in combination with [Lens] (Accessibility) Improve landmarks in Lens  #83597)
  • Bonus points: when adding a layer, move the focus to the first tabbable item of the layer panel just added instead of keeping it on the "add layer button".

Relevant WCAG Criteria: 2.4.3 Focus Order - Level A
@myasonik myasonik added bug Fixes for quality problems that affect the customer experience Project:Accessibility WCAG A loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Nov 17, 2020
@myasonik myasonik added this to Long-term goals in Lens via automation Nov 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@wylieconlon wylieconlon moved this from Long-term goals to Minor bugs in Lens Nov 17, 2020
@flash1293 flash1293 mentioned this issue Nov 18, 2020
Closed
20 tasks
@flash1293 flash1293 changed the title (Accessibility) Focus is lost when deleting a layer [Lens] (Accessibility) Focus is lost when deleting a layer Nov 18, 2020
@mbondyra mbondyra self-assigned this Nov 30, 2020
@mbondyra mbondyra mentioned this issue Dec 3, 2020
Merged
@myasonik myasonik added this to Needs triage in a11y Dec 14, 2020
@myasonik myasonik moved this from Needs triage to Serious in a11y Dec 15, 2020
Lens automation moved this from Minor bugs to Done Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens loe:small Small Level of Effort Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG A
Projects
a11y
Serious
Lens
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] (Accessibility) focus on adding/removing layers mbondyra/kibana
3 participants
@myasonik @mbondyra @elasticmachine