Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] (Accessibility) Improve landmarks in Lens #83597

Closed
myasonik opened this issue Nov 17, 2020 · 2 comments · Fixed by #84511
Closed

[Lens] (Accessibility) Improve landmarks in Lens #83597

myasonik opened this issue Nov 17, 2020 · 2 comments · Fixed by #84511
Assignees
Labels
accessibility best practice enhancement New value added to drive a business result Feature:Lens loe:small Small Level of Effort Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@myasonik
Copy link
Contributor

Ignoring global areas of Kibana, there are 3 main sections to Lens: the left sidebar, the center graph area, and the right sidebar.

Today, the center graph area is a main and the two other sections are nothing.

The fix

  • All 3 sections should be wrapped in a <main>.

    • Make sure to remove the main from where it is now (only 1 main is allowed on the page at a time).
    • Add aria-labelledby={idOfH1} to pave over some browser inconsistencies with how regions are named.
    • Improve the content in the <h1> for the unsaved state: right now, it just puts the heading at Unsaved but doesn't really tell you what page you're on or what's unsaved. Maybe Unsaved Lens Visualization is a better <h1> though feel free to suggest whatever you think might be most descriptive.
  • The 3 sections should be wrapped in <section> tags

    • Each section should have an <h2> with what that section is (can be visually hidden). Maybe "Fields list", "Visualization workspace", and "Layer controls" but y'all know your app best.
    • Add aria-labelledby={idOfChildH2} to the <section>
@myasonik myasonik added Project:Accessibility enhancement New value added to drive a business result loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens accessibility best practice labels Nov 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine kibanamachine added this to Long-term goals in Lens Nov 17, 2020
@flash1293 flash1293 changed the title (Accessibility) Improve landmarks in Lens [Lens] (Accessibility) Improve landmarks in Lens Nov 18, 2020
@mbondyra mbondyra self-assigned this Nov 30, 2020
Lens automation moved this from Long-term goals to Done Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility best practice enhancement New value added to drive a business result Feature:Lens loe:small Small Level of Effort Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants